[Fritzboxtr064] Synchronized access to fritzbox. #5484
Conversation
Prevent mixing up Digest nonce during concurrent remote calls. Signed-off-by: Oliver Probst <OliverProbst@gmx.de> (github: oprobst)
|
Ping. |
|
I'll start a review. Have you gotten any community members to try out your enhanced version? If not, please drop a thread in the community forum to request it. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/frithboxtr064-binding-fails-after-running-a-few-hours/36898/2 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/fritz-box-tr064-binding-problems-at-setup/45562/5 |
9037568
left a comment
There was a problem hiding this comment.
I don't see any obvious problems.
If we don't get any negative reviews from the community soon, we'll merge this and see how much screaming ensues.
|
Thanks, @oprobst ! |
Prevent mixing up Digest nonce during concurrent remote calls. Actually this change prevents concurrent calls at all.
This could happend if the function was called by more than one threat the same time.
Fix for [FritzboxTr064]: Still problems with "Could not read response from FritzBox. Unauthorized! ..." #5441
Signed-off-by: Oliver Probst OliverProbst@gmx.de (github: oprobst)