This repository was archived by the owner on May 17, 2021. It is now read-only.
Update GPIOGenericBindingProvider.java #5176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm proposing additional property in the GPIO binding item configuration which defines the initial value of the GPIO pin. With the old implementation it was always defined initially to LOW (0). There are cases when it is necessary the initial value to be HIGH (1). There is support for this in org.openhab.io.gpio but wasn't implemented in the configuration part of the GPIO binding.
9037568
suggested changes
May 2, 2017
Contributor
9037568
left a comment
There was a problem hiding this comment.
Please also update the README.md file appropriately.
| } else if (value.compareToIgnoreCase("low") == 0) { | ||
| config.direction = GPIOPin.DIRECTION_OUT_LOW; | ||
| } else { | ||
| logger.error("Unsupported value for initialValue (" + value + ") in configuration string '" |
Contributor
There was a problem hiding this comment.
Need to use parameterized logging instead of string concatenation.
Contributor
Author
There was a problem hiding this comment.
I tried to make changes with minimal modifications. I just copied logging from other parameters and didn't change the way it is used. If it is necessary I'll do this but then only this modification will be with parameterized logging and will differ from the other places in this class.
jokercho
added a commit
to jokercho/openhab1-addons
that referenced
this pull request
May 3, 2017
The modification is related to suggestion for openhab#5176
Closed
change requested from review
Contributor
|
Thanks, @jokercho ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm proposing additional property in the GPIO binding item configuration which defines the initial value of the GPIO pin. With the old implementation it was always defined initially to LOW (0). There are cases when it is necessary the initial value to be HIGH (1). There is support for this in org.openhab.io.gpio but wasn't implemented in the configuration part of the GPIO binding.