This repository was archived by the owner on May 17, 2021. It is now read-only.
[epsonprojector] Add additional ColorMode and AspectRatio values (from 5030UB projector) #5158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks, @jaydonoghue ! |
Member
|
It seems that this PR broke the build: https://openhab.ci.cloudbees.com/job/openHAB1-Addons/1458/console @jaydonoghue Could you please have a look? |
Contributor
Author
|
Yikes. Will fix. Looks like it doesn't like the dash
- J
… On Apr 20, 2017, at 5:48 AM, Kai Kreuzer ***@***.***> wrote:
It seems that this PR broke the build: https://openhab.ci.cloudbees.com/job/openHAB1-Addons/1458/console
@jaydonoghue Could you please have a look?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
|
I'm going to revert this to fix the build. |
Contributor
|
@jaydonoghue, I see you've fixed these in your repo. Would you care to submit a new PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a couple new items that work with the 5030UB projector