This repository was archived by the owner on May 17, 2021. It is now read-only.
[cul] Fix 2s blocking problem after sending FS20 message #5851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97e7c1a to
30362b2
Compare
Signed-off-by: Michael Klemm <michael@klemm-dachau.de>
Signed-off-by: Michael Klemm <michael@klemm-dachau.de>
Signed-off-by: Michael Klemm <michael@klemm-dachau.de>
Signed-off-by: Michael Klemm <michael@klemm-dachau.de>
Signed-off-by: Michael Klemm <michael@klemm-dachau.de>
Signed-off-by: Michael Klemm <michael@klemm-dachau.de>
Signed-off-by: Michael Klemm <michael@klemm-dachau.de>
MichaelKlemm
commented
Apr 27, 2019
Contributor
Author
MichaelKlemm
left a comment
There was a problem hiding this comment.
Ready for review.
Contributor
Author
|
Hi! How to proceed with this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CUL sending thread will produce a timeout of 2s if a command is sent that will not provide a response. This is the case when sending a FS20 message ("F" prefix). The major purpose of this PR is to provide a generic solution for such commands and only fix the problem for the FS20 protocol as there is no other equipment for testing available.
Additional Minor changes and refactorings: