这是indexloc提供的服务，不要输入任何密码
Skip to content
This repository was archived by the owner on May 17, 2021. It is now read-only.

[velux] Various bug fixes and enhancements #5833

Merged
merged 8 commits into from
Jul 22, 2019
Merged

[velux] Various bug fixes and enhancements #5833

merged 8 commits into from
Jul 22, 2019

Conversation

@gs4711
Copy link
Contributor

@gs4711 gs4711 commented Mar 16, 2019 •
edited
Loading

The following changes are provided:

  • Bugfix: Handle empty list of items properly.

  • Bugfix: HTTP/JSON communication.

  • Bugfix: aborting connection after sending error.

  • Bugfix: firmware revision properly returned.

  • Bugfix: close connections during binding shutdown/removal.

  • Bugfix: string representation and handling of ip addresses.

  • Bugfix: invalid use of myJsonBridge eliminated in case of LAN/WLAN config.

  • Bugfix: initial refresh of data for item added, handling of BRIDGE_REFRESH_MSECS fixed.

  • Bugfix: refresh only readable items.

  • Bugfix/enhancement: adapted logging (more infos, less warnings).

  • Enhancement: comments for activation with OH2.

  • Enhancement: more information during actuator state modification for debugging.

  • Enhancement: new channel timestamp.

  • Enhancement: intensive logging for recognition of Somfy devices.

  • Enhancement: optional handling for inversed actuators.

  • Enhancement: eliminating usage of org.apache.commons.lang.StringUtils.isNotBlank.

  • Enhancement: proper handling of unknown config items.

  • Enhancement: more infos about debug settings in README.

  • Enhancement: more infos in loglevel trace.

  • Enhancement: provide infos about WLAN config.

  • Enhancement: more detailed configuration in README added.

  • Enhancement: better error handling for unknown scenes (virtual rollershutters).

  • Enhancement: handling bad serial numbers (Somfy).

  • Enhancement: reload action for retrieving all infos from bridge.

@gs4711 gs4711 changed the title Minor changes for OH2 esp. for proper configuration [Velux] Minor changes for OH2 esp. for proper configuration Mar 16, 2019
@9037568
Copy link
Contributor

9037568 commented Mar 16, 2019

If the plan is to create an OH2 binding, that should be done in the OH2 repo.

@gs4711
Copy link
Contributor Author

gs4711 commented Mar 16, 2019

If the plan is to create an OH2 binding, that should be done in the OH2 repo.

Yes, it will be fully OH2 compliant with a separate initialization module for dealing with things.

This bug fix is necessary as OH2 calls the configuration method with a null pointer instead of an empty Dictionary.

@gs4711
[binding.velux] fix: eliminate of race condition during startup (init…
bf4b3df 
… vs. HouseStatusMonitoring).

[binding.velux] fix: prevent invalid parameters when running under OH2 with compat layer.
[binding.velux] fix: adapt library path for JSON helper library (eliminating wrning during startup).
[binding.velux] fix: waiting too long when no scenes are defined.
Signed-off-by: Guenther Schreiner <guenther.schreiner@smile.de>
@gs4711 gs4711 changed the title [Velux] Minor changes for OH2 esp. for proper configuration [Velux] bug fixes: race condition during startup, invalid parameters with compat layer, library path, waiting too long. Mar 16, 2019
@openhab-bot
Copy link
Collaborator

openhab-bot commented Mar 24, 2019

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/velux-new-openhab2-binding-feedback-welcome/32926/130

@openhab-bot
Copy link
Collaborator

openhab-bot commented Apr 9, 2019

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/use-velux-binding-in-oh-1-x/71975/20

@gs4711 gs4711 changed the title [Velux] bug fixes: race condition during startup, invalid parameters with compat layer, library path, waiting too long. [Velux] bug fixes: empty item list. Enhanced README. Jul 1, 2019
@gs4711
Copy link
Contributor Author

gs4711 commented Jul 1, 2019

Thx, @wborn, for all the license adaptions! Now, this PR is adapted to the already approved #5843. Therefore, only minor changes have been left over.

@openhab-bot
Copy link
Collaborator

openhab-bot commented Jul 12, 2019

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/velux-new-openhab2-binding-feedback-welcome/32926/298

@gs4711
Copy link
Contributor Author

gs4711 commented Jul 19, 2019

Hopefully one of the maintainers is reading this: the list of changes is mentioned/updated in the initial comment.

@gs4711
[binding.velux] Bugfix: Handle empty list of items properly.
9fd9023 
    [binding.velux] Bugfix: HTTP/JSON communication.
    [binding.velux] Bugfix: Aborting connection after sending error.
    [binding.velux] Bugfix: Firmware revision properly returned.
    [binding.velux] Bugfix: Close connections during binding shutdown/removal.
    [binding.velux] Bugfix: String representation and handling of ip addresses.
    [binding.velux] Bugfix: Invalid use of myJsonBridge eliminated in case of LAN/WLAN config.
    [binding.velux] Bugfix: Initial refresh of data for item added, handling of BRIDGE_REFRESH_MSECS fixed.
    [binding.velux] Bugfix: Refresh only readable items.
    [binding.velux] Bugfix/enhancement: Adapted logging (more infos, less warnings).
    [binding.velux] Enhancement: Comments for activation with OH2, more infos about debug settings in README, more detailed configuration in README added.
    [binding.velux] Enhancement: More information during actuator state modification for debugging, more infos in loglevel trace.
    [binding.velux] Enhancement: New channel timestamp.
    [binding.velux] Enhancement: New channel Reload for retrieving all infos from bridge.
    [binding.velux] Enhancement: Optional handling for inversed actuators.
    [binding.velux] Enhancement: Eliminating usage of org.apache.commons.lang.StringUtils.isNotBlank.
    [binding.velux] Enhancement: Proper handling of unknown config items.
    [binding.velux] Enhancement: Provide infos about WLAN config.
    [binding.velux] Enhancement: Better error handling for unknown scenes (virtual rollershutters).
    [binding.velux] Enhancement: Intensive logging for recognition of Somfy devices.
    [binding.velux] Enhancement: Handling bad serial numbers (Somfy).

Signed-off-by: Guenther Schreiner <guenther.schreiner@smile.de>
@kaikreuzer
Copy link
Member

kaikreuzer commented Jul 19, 2019

Thx, @wborn, for all the license adaptions!

Were those somehow lost again? I see a lot of non-standard license texts and EPLv1 mentioned in them. Could you check and possibly re-run a mvn license:format?

@kaikreuzer
Copy link
Member

kaikreuzer commented Jul 19, 2019

Yes, it will be fully OH2 compliant with a separate initialization module for dealing with things.

I am not fully clear on what that means. As it is a 1.x binding, it must not refer to Things etc., so I do nut understand why you have added things files here and removed the binding configuration.

This bug fix is necessary as OH2 calls the configuration method with a null pointer instead of an empty Dictionary.

This PR seems to do much more that this bugfix by now...

@gs4711
Copy link
Contributor Author

gs4711 commented Jul 19, 2019

Could you check and possibly re-run a mvn license:format?

Unfortunatelly rhe re-run of a mvn license:format does not lead to any changes???

@gs4711
Copy link
Contributor Author

gs4711 commented Jul 19, 2019

This PR seems to do much more that this bugfix by now...

Yes, of course: Due to the [feedback] (https://community.openhab.org/t/velux-new-openhab2-binding-feedback-welcome/32926/354) of users with OH1 and OH2, this PR contains nine bugfixes and ten extensions since 16/03/2019 in addition.

@gs4711
[binding.velux] EPLv1 replaced, log level decreased and README updat…
600073e 
…ed for Somfy devices.

Signed-off-by: Guenther Schreiner <guenther.schreiner@smile.de>
@gs4711
Copy link
Contributor Author

gs4711 commented Jul 20, 2019

I see a lot of non-standard license texts and EPLv1

Thanks for this notice: Now, those files are manually adapted.

@kaikreuzer
Copy link
Member

kaikreuzer commented Jul 20, 2019

Thanks for the quick update, looks much better now.
So my remaining question is this one from above:

As it is a 1.x binding, it must not refer to Things etc., so I do nut understand why you have added things files here and removed the binding configuration.

@gs4711
Copy link
Contributor Author

gs4711 commented Jul 20, 2019

So my remaining question is this one from above:

As it is a 1.x binding, it must not refer to Things etc., so I do nut understand why you have added things files here and removed the binding configuration.

The separation of the binding configuration into things files originated in the strange behaviour of paperUI which does not handle this 1.x binding properly. This part of the change (which came from the adoptions towards a full 2.x binding) could be skipped as it did not resolve this issue completely.

@gs4711 gs4711 changed the title [Velux] bug fixes: empty item list. Enhanced README. [Velux] Bugfixes (Empty list of items, HTTP/JSON, sending error, binding shutdown/removal, channel values) plus Enhancements (documentation, new channels timestamp+reload, optional inversed actuator values, support of Somfy devices) Jul 21, 2019
@kaikreuzer
Copy link
Member

kaikreuzer commented Jul 21, 2019

This part of the change (which came from the adoptions towards a full 2.x binding) could be skipped

Yes, I would suggest this as Thing files must not be part of any 1.x binding and all configuration must be done on the binding level (as it is before this PR).

@gs4711
[binding.velux] ESH-INF/thing removed, config spec. moved into ESH-I…
402599d 
…NF/binding/binding.xml

Signed-off-by: Guenther Schreiner <guenther.schreiner@smile.de>
@gs4711
Copy link
Contributor Author

gs4711 commented Jul 21, 2019

Yes, I would suggest this as Thing files must not be part of any 1.x binding and all configuration must be done on the binding level (as it is before this PR).

Adapted as suggested.

kaikreuzer
kaikreuzer suggested changes Jul 21, 2019
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks pretty good now!
Just 2 small comments to address, then we can merge.

gs4711 added 3 commits July 22, 2019 12:18
@gs4711
[binding.velux] Bugfix: Integration parts (as decribed at 1.x Add-on…
66d8b6f 
… to the distribution)

Signed-off-by: Guenther Schreiner <guenther.schreiner@smile.de>
@gs4711
[binding.velux] README adapted, translations removed.
b61cdaf 
Signed-off-by: Guenther Schreiner <guenther.schreiner@smile.de>
@gs4711
[binding.velux] OH2 translations removed.
e94f420 
Signed-off-by: Guenther Schreiner <guenther.schreiner@smile.de>
kaikreuzer
kaikreuzer approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@kaikreuzer kaikreuzer merged commit a704829 into openhab:master Jul 22, 2019
@gs4711
Copy link
Contributor Author

gs4711 commented Jul 22, 2019

Thanks, @kaikreuzer, a lot!

@openhab-bot
Copy link
Collaborator

openhab-bot commented Jul 22, 2019

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/velux-new-openhab2-binding-feedback-welcome/32926/364

@gs4711
Copy link
Contributor Author

gs4711 commented Jul 26, 2019

@kaikreuzer ,

first of all, thanks for the merge of the #5833.

I am not fully clear on what that means. As it is a 1.x binding, it must not refer to Things etc., so I do not understand why you have added things files here and removed the binding configuration.

Sorry to bother you but after removing the ESH/things stuff the PaperUI does not provide any thing information for this compat binding. Therefore, having eliminated the bridge and thing declaration, the config-file-based configuration is the only way to handle it with PaperUI.

An ideas?

Best regards, Guenther

@kaikreuzer
Copy link
Member

kaikreuzer commented Jul 26, 2019

That's exactly how 1.x bindings work. Note that the main feature of 2.x bindings is to bring thing & Paper UI support, which does not exist in 1.x.

@andrewfg
Copy link
Contributor

andrewfg commented Aug 8, 2019 •
edited
Loading

Hi Guenter @gs4711 — How are you getting on with your Velux OH v2 binding? In the meantime, I have migrated the v1 version of the NeoHub binding to v2, and also written a completely new v2 binding for Siemens smart thermostats. And now the only equipment in my home which is not on OH v2 are the Velux roof windows. So I have some skills, some motivation, and the test equipment (KLF200 and windows), to help you with the v1 -> v2 migration. Do you already have a beta of the v2 binding somewhere that I can play with?

@gs4711
Copy link
Contributor Author

gs4711 commented Aug 8, 2019 via email

@andrewfg
Copy link
Contributor

andrewfg commented Aug 9, 2019

I notice that PR#4416 seems also to be an OH2 binding for Velux equipment ?? - is there some coordination with that?

@wborn wborn added this to the 1.14.0 milestone Dec 7, 2019
@wborn wborn added the bug label Dec 7, 2019
@kaikreuzer kaikreuzer changed the title [Velux] Bugfixes (Empty list of items, HTTP/JSON, sending error, binding shutdown/removal, channel values) plus Enhancements (documentation, new channels timestamp+reload, optional inversed actuator values, support of Somfy devices) [velux] Various bug fixes and enhancements Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

6 participants

@gs4711 @9037568 @openhab-bot @kaikreuzer @andrewfg @wborn