这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on May 17, 2021. It is now read-only.

Conversation

@crxporter
Copy link
Contributor

This will add the ability to add on level items into OpenHAB for the Insteon PLM binding. Items should be number type with a range from 0 to 255. The feature works the same as other features in the binding (LEDBrightness and RampRate).

RampRate is Insteon message 0x05. LEDBrightness is Insteon message 0x07. OnLevel (new) is Insteon message 0x06.

Adds on level feature to Insteon PLM device_features.xml. Ability to change 2477D brightness level when the switch is controlled locally (the switch is physically pressed).
Adds onlevel feature to insteon product 2477D - ability to change on level of a dimmer switch when controlled locally - at the switch.
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/improving-support-for-2441v-insteon-thermostat-adaptor-for-venstar/64504/8

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/insteon-my-own-feature-new-i-think-onlevel/52141/1

@9037568 9037568 requested a review from berndpfrommer January 18, 2019 23:51
@9037568
Copy link
Contributor

9037568 commented Jan 18, 2019

LGTM, but let's see if @berndpfrommer has any comments.

@9037568 9037568 changed the title Add on level feature to Insteon PLM 2477D dimmer [InsteonPLM] Add OnLevel feature to Insteon PLM 2477D dimmer Jan 18, 2019
@berndpfrommer
Copy link
Contributor

@crxporter Thanks for the contribution!
Apologies I cannot test it since I no longer have a working OH dev environment. The change looks good to me. The only comment I have is that this feature is probably supported by more than just the 2477D. Support for the other devices can be added later, so from my perspective this is good to go.

Copy link
Contributor

@berndpfrommer berndpfrommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@9037568 9037568 added this to the 1.14.0 milestone Jan 26, 2019
@9037568
Copy link
Contributor

9037568 commented Jan 26, 2019

Thanks, @crxporter !

@9037568 9037568 merged commit 1541764 into openhab:master Jan 26, 2019
@kaikreuzer kaikreuzer changed the title [InsteonPLM] Add OnLevel feature to Insteon PLM 2477D dimmer [InsteonPLM] Added OnLevel feature to Insteon PLM 2477D dimmer Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants