[dynamodb] Updated DynamoDB SDK #5722
Conversation
|
@ssalonen Could you possibly do a review of this? |
|
@9037568 my pleasure, will have a look during this year still... |
There was a problem hiding this comment.
Looks pretty good. Just small issue with .classpath referring to wrong jackson-databind. For some reason I'm getting the correct version by executing steps in README... I did get slightly different output for dependencies.html (extra table with links to maven central) but all the important details are there correctly.
Verified that integration tests (org.openhab.persistence.dynamodb.test) pass against real AWS -- this gives pretty good confidence that nothing breaks with the SDK update. We used to have breaking SDK changes, breaking things in runtime (in integration tests) but not compile time.
Also, just for posterity, new region needs no extra configuration definition (ESH-INF/config/*.xml) changes since regions are validated in runtime. Also, list of accepted regions are not mentioned in README either so that is fine as is.
Also verified the jars match the versions I am getting, so that is fine.
| <classpathentry exported="true" kind="lib" path="lib/jackson-annotations-2.6.0.jar"/> | ||
| <classpathentry exported="true" kind="lib" path="lib/jackson-core-2.6.7.jar"/> | ||
| <classpathentry exported="true" kind="lib" path="lib/jackson-databind-2.6.7.1.jar"/> | ||
| <classpathentry exported="true" kind="lib" path="lib/jackson-databind-2.6.7.jar"/> |
There was a problem hiding this comment.
Everywhere else we have jackson-databind-2.6.7.2.jar So this is probably an mistake?
Furthermore, I did get jackson-databind-2.6.7.2.jar when following the README, copy-paste accident?
For developers. Inspired by PR openhab#5722 Signed-off-by: Sami Salonen <ssalonen@gmail.com>
For developers. Inspired by PR #5722 Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Furthermore, introduced script to automate SDK updates in future Replaces openhab#5722 Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Also - scripts to update SDK Replaces openhab#5722 Signed-off-by: Sami Salonen <ssalonen@gmail.com>
|
New PR with more recent SDK: #5827 |
|
Closing in favor of newer PR. |
DynamoDB SDK updated to 1.11.457. This update includes support for the Paris (eu-west-3) region.
Tested with openHAB version 2.3.0.