This repository was archived by the owner on May 17, 2021. It is now read-only.
[Telegram] Add support for file protocol #5721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Hilbush <mark@hilbush.com>
9037568
suggested changes
Dec 3, 2018
Contributor
9037568
left a comment
There was a problem hiding this comment.
Neat fix. Just request a couple of minor tweaks...
...org.openhab.action.telegram/src/main/java/org/openhab/action/telegram/internal/Telegram.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mark Hilbush <mark@hilbush.com>
Contributor
Author
|
Thanks for the feedback. I changed based on your comments.
Was @wborn's idea. 👍 |
Contributor
|
Thanks, @mhilbush ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/openhab/openhab2-addons/issues/4286
Adds support for sending images contained on the local openHAB host's file system. Image files are specified using the file protocol (e.g.
file:///path/to/local/image.jpg)IDK why the README shows that the entire doc changed, as I only made several small additions.
Also the IDE forced several formatting changes in addition to the addition to the code for supporting the file protocol.
Signed-off-by: Mark Hilbush mark@hilbush.com