This repository was archived by the owner on May 17, 2021. It is now read-only.
[PLCBus] Fix addon crash when two commands are sent in quick succession #5707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9037568
reviewed
Nov 14, 2018
...rc/main/java/org/openhab/binding/plcbus/internal/protocol/AbstractReceiveFrameContainer.java
Outdated
Show resolved
Hide resolved
This caused two different openhab threads to concurrently receive bytes from the serial port. In turn, each thread received every other byte, and so both threads saw corrupted frames. Even worse - threads would get stuck waiting for response, and entire openhab was unresponsive until restarted. Adding synchronized helped. I've also improved logging of error (which is now not being thrown in this scenario).
cb4179a to
027acf5
Compare
Contributor
|
Thanks, @pit3k ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused two different openhab threads to concurrently receive
bytes from the serial port. In turn, each thread received every other byte,
and so both threads saw corrupted frames. Even worse - threads would get
stuck waiting for response, and entire openhab was unresponsive until
restarted.
Adding synchronized helped. I've also improved logging of error (which is
now not being thrown in this scenario).