这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on May 17, 2021. It is now read-only.

Conversation

@andre77
Copy link
Contributor

@andre77 andre77 commented Sep 7, 2018

fixed name resolution of address book entries.
the name resolution did not work 100% correct, if there are some white spaces in between the number, i.e. like this '+49 40 123 456 789'

@9037568
Copy link
Contributor

9037568 commented Sep 7, 2018

Why? I don't see any defects stating that name resolution doesn't work.
Have you had any community testing for this change?

@andre77
Copy link
Contributor Author

andre77 commented Sep 7, 2018

@9037568 just put some white spaces into a tel number inside your address book on the fritz box ( like this '+49 40 123 456 789') and make a call from this number. the current version will not find a match because of the white spaces

@9037568
Copy link
Contributor

9037568 commented Sep 7, 2018

Then don't put the whitespaces in.
I don't use or even have a fritzbox.

@andre77
Copy link
Contributor Author

andre77 commented Sep 7, 2018

@9037568
its not forbidden to put white spaces into the tel numbers. it makes them even more readable. so why not?
most of the phones like for example iphone even add a white space automatically to separate the prefix of the tel number.
but why are you worried about the changes for a fritz box binding, if you even don't have one? :-)
or are u using the binding with another device, which supports the TR064 protocol?

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@9037568 I can confirm that this is an issue - as a user, you have no idea where the number might have spaces and if you want to match it, you have to rely on a decent formatting - otherwise all rules etc. would have to do the removal of spaces by themselves. So the change lgtm and it is useful for me as a Fritz!Box owner :-)

@9037568 9037568 added this to the 1.13.0 milestone Sep 7, 2018
@9037568 9037568 merged commit 6f4eabb into openhab:master Sep 7, 2018
@9037568
Copy link
Contributor

9037568 commented Sep 7, 2018

Thanks, @kaikreuzer, for the confirmation.
Thanks for the patch, @andre77 !

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/fritzbox-tr064-binding-problem-resolving-external-call-number-to-name-with-a-google-synced-phonebook/39609/5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants