This repository was archived by the owner on May 17, 2021. It is now read-only.
[ecobee action] OH2 Compatibility (fixes #3963) #4029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… selection string and Numbers.
teichsta
added a commit
that referenced
this pull request
Feb 12, 2016
[ecobee action] OH2 Compatibility (fixes #3963)
Member
|
Thanks @watou for compiling this PR! |
Contributor
Author
|
Thank you, Thomas, for merging this (and for the millions of other things you do). I've updated the relevant wiki pages to document this breaking change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3963.
Rid action methods of Items, BigDecimal and Integer, in preference to selection string and Numbers. Changes were required for compatibility with openHAB 2. Both action and binding bundles must be upgraded together.
Breaking Change
Method signatures have changed incompatibly. The first parameter is no longer an Item but is now the thermostat(s) to which to target the action, such as "254319432" (one or more thermostat IDs separated with commas) or "condo.*" (all registered under condo account) or "/Toronto/BldgA" (a management set), just as it's done in the binding.
I will update the doc and example after merge.