This repository was archived by the owner on May 17, 2021. It is now read-only.
add configurable refresh interval #4773
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of DMX transmitter is only transmitting if the universe has changed. This is checked every 35ms. The data is never re-transmitted if it does not change. If a receiver has been restarted after the last transmit it will not receive data until a channel changed. Some connections (as the upcoming E1.31) need to be refreshed by standrad definition. This change introduces a "refresh" configuration option. The default is -1 (never refresh), which is compatible with the current implementation. A value of 0 would refresh every 35ms, another value would transmit data if it has been changed or the last transmission is more than (value) ms in the past. Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Member
Author
|
Mhm. This obviously is wrong. Can someone explain why this is happening? This is the done with the Eclipse install for OH1 addons. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of DMX transmitter is only transmitting if the universe has changed. This is checked every 35ms. The data is never re-transmitted if it does not change. If a receiver has been restarted after the last transmit it will not receive data until a channel changed. Some connections (as the upcoming E1.31) need to be refreshed by standrad definition.
This change introduces a "refresh" configuration option. The default is -1 (never refresh), which is compatible with the current implementation. A value of 0 would refresh every 35ms, another value would transmit data if it has been changed or the last transmission is more than (value) ms in the past.
Signed-off-by: Jan N. Klug jan.n.klug@rub.de