This repository was archived by the owner on May 17, 2021. It is now read-only.
[ecobee] Added quick poll after update, command or action. #3568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ac569e to
7914383
Compare
Member
There was a problem hiding this comment.
it might be helpful to the reason why polling is skipped (due to a missing token)
Contributor
Author
There was a problem hiding this comment.
I rely on the refreshTokens() method to log the specific error and then return false, so the caller only has to report how it affects control flow.
Member
|
lgtm … just one small remark which might help debugging the binding. Please go ahead and merge if you like. |
Contributor
Author
|
I will merge now and thanks, @teichsta. |
watou
added a commit
that referenced
this pull request
Dec 25, 2015
[ecobee] Added quick poll after update, command or action.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: added optional
ecobee:granularityandecobee:quickpollconfig properties; polling the Ecobee API will occur much sooner after the binding has sent an update, command or action call to Ecobee in order to give quicker feedback to the binding.Changed the polling logic in the Ecobee binding to invoke the
execute()method based on optionalecobee:granularityconfig property (default 5000ms). On each of those, check to see if it's time to poll the Ecobee API. Normal polling continues to use the optionalecobee:refreshconfig property (default 180000ms). However, after a successful update, command or action call to the Ecobee API, the next poll will occur afterecobee:quickpollmilliseconds have passed (optional, defaults to 6000). So existing configurations are compatible, but the binding will perform a poll about 6-11 seconds after a successful write to the Ecobee API.