New DSC Alarm Action #3266
New DSC Alarm Action #3266
Conversation
|
Thanks @mrguessed. The errors are fixed. I appreciate it. |
|
Thanks @RSStephens for this contribution (and @mrguessed for the first review). Overall this PR lgtm however i've also found some small issues. Could you finally please squash your commits into one? Thanks … |
Incorporating DSC Alarm action into openhab. DSC Alarm Action updates. Create README.md File Fix README.md Another README.md Fix Still Another README.md Fix README.md Spelling Correction Final fixes for Actions Implimentation Minor Typo Errors Fixed PR Review Fixes Fixes made to pull request after review.
|
Hello Thomas, I made the changes you requested and squashed the commits. Thank you. |
There was a problem hiding this comment.
Very minor: it's the action, not the binding.
|
Looking at the last file Thomas changed for #2967, it looks like the file |
|
Thanks again @RSStephens and @watou for the thorough review! |
|
@RSStephens , could you update the Actions wiki page with either the documentation for this new bundle, or a link to a page dedicated to the new bundle? Also, consider adding a note and link to the binding wiki page to explain the new functionality that DSC alarm panel binding users could have if they added in the new action bundle. Make sure to note the availability of the action bundle in openHAB 1.8 and later releases. Thank you! |
|
Yes I will update the wiki. Thanks. |
This is a new implementation for a DSC Alarm Action to add the ability to send DSC Alarm commands through the rule subsystem. This was a request made from the openHAB community forum as seen here: https://community.openhab.org/t/dsc-binding-how-to-send-a-command-string-similar-to-keypad/2708/9.