这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on May 17, 2021. It is now read-only.

Conversation

@drewwaite
Copy link

Issue #3662

@drewwaite
Copy link
Author

Attempt #2. That looks better.

@cdjackson
Copy link
Contributor

The PR looks better (thanks), but I don't think you've put the reference in the right place? If this is meant to be for the RGB, then it's not correct as you've put it in with the roller shutter...

@cdjackson cdjackson self-assigned this Jan 1, 2016
@cdjackson
Copy link
Contributor

Oh - to fix this, don't change the PR - just move the lines to the right place (assuming it's wrong), recommit and push - it will update the PR automatically.

@drewwaite
Copy link
Author

Opps. My error. I didn't realise the "item label" was at the bottom. Fixed.

@cdjackson
Copy link
Contributor

It is in this case, and probably most cases, but you need to look at the structure of the XML - the reference needs to go inside the Product tag for the right product - it’s not about the order or the elements…

On 1 Jan 2016, at 14:25, Andrew Waite notifications@github.com wrote:

Opps. My error. I didn't realise the "item label" was at the bottom. Fixed.


Reply to this email directly or view it on GitHub #3664 (comment).

@cdjackson
Copy link
Contributor

Thanks.

cdjackson added a commit that referenced this pull request Jan 1, 2016
Fibaro RGBW updated references.
@cdjackson cdjackson merged commit 8df3654 into openhab:master Jan 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants