-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added support to Netatmo for unit system and pressure unit #2820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the BigDecimal multiplier values were static final class variables, you wouldn't have to "new" them with each conversion, which might be more efficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, changes made.
|
Hi @robnielsen thanks for this enhancement which looks good to me (and @watou as well). Could you please squash your commits into one finally? Thanks, Thomas E.-E. |
…it (mbar, inHg, mmHg), defaults to Metric and mbar.
|
Wiki has been updated |
|
Hey Rob, could you spell out in the wiki page how to specify metric as an openhab.cfg choice? I know Metric is the default, but if someone gives |
|
Hi John, I updated the Wiki with your suggestions. Thanks! |
|
Thank you, Rob, for making the Netatmo binding better! |
Added support to Netatmo for unit system and pressure unit
|
Thanks @robnielsen! |
Implemented both unit system and pressure unit in the same manner as implemented by the Netatmo apps (web, Android). Unit systems supported are Metric and US. Pressure units supported are mbar, inHg, and mmHg.