这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on May 17, 2021. It is now read-only.

Conversation

@robnielsen
Copy link
Contributor

Implemented both unit system and pressure unit in the same manner as implemented by the Netatmo apps (web, Android). Unit systems supported are Metric and US. Pressure units supported are mbar, inHg, and mmHg.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the BigDecimal multiplier values were static final class variables, you wouldn't have to "new" them with each conversion, which might be more efficient.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, changes made.

@teichsta
Copy link
Member

Hi @robnielsen thanks for this enhancement which looks good to me (and @watou as well). Could you please squash your commits into one finally? Thanks, Thomas E.-E.

@teichsta teichsta added this to the 1.8.0 milestone Jun 30, 2015
…it (mbar, inHg, mmHg), defaults to Metric and mbar.
@robnielsen
Copy link
Contributor Author

Hi @teichsta, I've squished the commits, and thanks @watou for your help. Rob

@robnielsen
Copy link
Contributor Author

Wiki has been updated

@watou
Copy link
Contributor

watou commented Jul 2, 2015

Hey Rob, could you spell out in the wiki page how to specify metric as an openhab.cfg choice? I know Metric is the default, but if someone gives netatmo:unitsystem=Metric instead of netatmo:unitsystem=metric, is it case insensitive? Just trying to avoid future confusion!

@robnielsen
Copy link
Contributor Author

Hi John, I updated the Wiki with your suggestions. Thanks!

@watou
Copy link
Contributor

watou commented Jul 2, 2015

Thank you, Rob, for making the Netatmo binding better!

teichsta added a commit that referenced this pull request Jul 6, 2015
Added support to Netatmo for unit system and pressure unit
@teichsta teichsta merged commit 2027f7d into openhab:master Jul 6, 2015
@teichsta
Copy link
Member

teichsta commented Jul 6, 2015

Thanks @robnielsen!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants