Extend chart periods to 3Y, 5Y and 10Y #2190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Job #1274: Bundle Size — 15.81MiB (+0.3%).Important Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
  
Bundle size by type
View job #1274 report View stefan-hoehn:chart_period_extens... branch activity |
florian-h05
approved these changes
Nov 26, 2023
Contributor
florian-h05
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I guess especially the 10 year range might take a year to load for those who have a datapoint every minute in their persistence ;-)
Contributor
Author
|
I agree, I don't want anyone to complain if loading takes ages ;-) |
florian-h05
added a commit
to florian-h05/openhab-webui
that referenced
this pull request
Dec 15, 2023
Follow-up for openhab#2190. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Merged
florian-h05
added a commit
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow further settings 3Y, 5Y, 10Y for dynamic period of chart.