这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix developer sidebar conceals "Other Apps" panel #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2023
Merged

Fix developer sidebar conceals "Other Apps" panel #2180

merged 1 commit into from
Nov 26, 2023

Conversation

@florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Nov 19, 2023

Fixes #2177.

@florian-h05
Fix developer sidebar conceals "Other Apps" panel
f2d83db 
Fixes openhab#2177.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner November 19, 2023 14:10
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Nov 19, 2023
@relativeci
Copy link

relativeci bot commented Nov 19, 2023

Job #1262: Bundle Size — 15.8MiB (+0.27%).

f2d83db(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1262		      Baseline
Job #1158
Regression  Initial JS 1.89MiB(+13.11%) 1.67MiB
Regression  Initial CSS 609.63KiB(+0.12%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 3027(+78.06%) 1700
Regression  Duplicate Modules 173(+92.22%) 90
Improvement  Duplicate Code 1.61%(-17.44%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1262		      Baseline
Job #1158
Regression  JS 9.28MiB (+0.29%) 9.25MiB
Regression  Other 4.74MiB (+0.31%) 4.73MiB
Regression  CSS 860.87KiB (+0.16%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1262 report View florian-h05:fix-2177 branch activity

ghys
ghys approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@ghys ghys merged commit 95b4899 into openhab:main Nov 26, 2023
@ghys ghys added this to the 4.1 milestone Nov 26, 2023
@florian-h05 florian-h05 deleted the fix-2177 branch November 26, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ghys ghys ghys approved these changes

Assignees

No one assigned

Labels

bug Something isn't working main ui Main UI

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

Developer sidebar preventing access to other UIs

2 participants

@florian-h05 @ghys