Developer sidebar: Support searching (in) sitemaps #2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Job #1210: Bundle Size — 15.79MiB (+0.2%).Warning Bundle contains 16 duplicate packages – View duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
  
Bundle size by type
View job #1210 report View florian-h05:devbar-search-sitema... branch activity |
ghys
approved these changes
Nov 21, 2023
Member
ghys
left a comment
There was a problem hiding this comment.
I won't ever use it but I don't see why not!
Comment on lines
577
to
+581
| Promise.resolve(this.cachedObjects[1]), | ||
| Promise.resolve(this.cachedObjects[2]), | ||
| Promise.resolve(this.cachedObjects[3]), | ||
| Promise.resolve(this.cachedObjects[4]) | ||
| Promise.resolve(this.cachedObjects[4]), | ||
| Promise.resolve(this.cachedObjects[5]) |
Member
There was a problem hiding this comment.
This is becoming quite embarrassing, but okay ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the developer sidebar search to sitemaps, where uid, label and slots are searched for the query.
Case is ignored.