这是indexloc提供的服务，不要输入任何密码
Skip to content

[BasicUI] Fix updating of the chart period parameter in URL #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2023
Merged

[BasicUI] Fix updating of the chart period parameter in URL #2162

merged 1 commit into from
Nov 26, 2023

Conversation

@lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Nov 4, 2023 •
edited
Loading

The period parameter syntax was extended.
Depends on openhab/openhab-core#3863

Also add few new default periods in the selection of chart period

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo added enhancement New feature or request basic ui Basic UI main ui Main UI awaiting other PR Depends on another PR labels Nov 4, 2023
@lolodomo lolodomo requested a review from a team as a code owner November 4, 2023 11:47
@relativeci
Copy link

relativeci bot commented Nov 4, 2023 •
edited
Loading

Job #1239: Bundle Size — 15.75MiB (-0.08%).

e0188bf(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1239		      Baseline
Job #1158
Regression  Initial JS 1.85MiB(+11.05%) 1.67MiB
Regression  Initial CSS 609.06KiB(+0.03%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 2987(+75.71%) 1700
Regression  Duplicate Modules 173(+92.22%) 90
Improvement  Duplicate Code 1.61%(-17.44%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 2 regressions Improvement 1 improvement
                 Current
Job #1239		      Baseline
Job #1158
Improvement  JS 9.24MiB (-0.15%) 9.25MiB
Regression  Other 4.73MiB (~+0.01%) 4.73MiB
Regression  CSS 860.29KiB (+0.09%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1239 report View lolodomo:chart_6M_2Y branch activity

@lolodomo lolodomo changed the title Add 6 months and 2 years periods for sitemap charts Add 3 and 6 months and 2 years periods for sitemap charts Nov 4, 2023
@lolodomo lolodomo changed the title Add 3 and 6 months and 2 years periods for sitemap charts [BasicUI] Accept ISI8601 duration notation for chart period Nov 18, 2023
@lolodomo lolodomo removed the main ui Main UI label Nov 18, 2023
@lolodomo
[BasicUI] Fix updating of the chart period parameter in URL
8870ca0 
The period parameter syntax was extended.
Depends on openhab/openhab-core#3863

Also add few new default periods in the selection of chart period

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo changed the title [BasicUI] Accept ISI8601 duration notation for chart period [BasicUI] Fix updating of the chart period parameter in URL Nov 18, 2023
@mherwege
Copy link
Contributor

mherwege commented Nov 19, 2023

LGTM I will look into adapting the UI sitemap definition checks.

@lolodomo lolodomo removed the awaiting other PR Depends on another PR label Nov 24, 2023
@lolodomo
Copy link
Contributor Author

lolodomo commented Nov 26, 2023

@kaikreuzer : a small change that is a consequence of the change in core.

kaikreuzer
kaikreuzer approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 3e27463 into openhab:main Nov 26, 2023
@kaikreuzer kaikreuzer added this to the 4.1 milestone Nov 26, 2023
@lolodomo lolodomo deleted the chart_6M_2Y branch November 26, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees

No one assigned

Labels

basic ui Basic UI enhancement New feature or request

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

3 participants

@lolodomo @mherwege @kaikreuzer