这是indexloc提供的服务，不要输入任何密码
Skip to content

Things list: Add grouping by location & Display location in list entries #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2023
Merged

Things list: Add grouping by location & Display location in list entries #2107

merged 1 commit into from
Oct 8, 2023

Conversation

@d51x
Copy link
Contributor

@d51x d51x commented Oct 3, 2023 •
edited by florian-h05
Loading

Closes #2099.

@d51x d51x requested a review from a team as a code owner October 3, 2023 17:08
@d51x d51x mentioned this pull request Oct 3, 2023
Closed
@d51x d51x changed the base branch from 4.0.x to main October 3, 2023 17:16
@d51x d51x changed the base branch from main to 4.0.x October 3, 2023 17:17
@d51x
Copy link
Contributor Author

d51x commented Oct 3, 2023

Discussion #2099

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Oct 3, 2023
florian-h05
florian-h05 approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Nice addition.

BTW: You do not need to manually request review from those who GitHub suggests ... the maintainer group is automatically requested for review and all maintainers are notified.

@florian-h05 florian-h05 added the rebuild trigger a new Jenkins job label Oct 8, 2023
@florian-h05 florian-h05 changed the title [MainUI] added grouping things by location, added location into thing… Things list: Add grouping by location & Display location in list entries Oct 8, 2023
@florian-h05 florian-h05 changed the base branch from 4.0.x to main October 8, 2023 13:07
@florian-h05 florian-h05 changed the base branch from main to 4.0.x October 8, 2023 13:08
@d51x @florian-h05
[MainUI] added grouping things by location, added location into thing…
f447c36 
… subtitle

Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
@florian-h05 florian-h05 changed the base branch from 4.0.x to main October 8, 2023 13:17
@florian-h05
Copy link
Contributor

florian-h05 commented Oct 8, 2023

@d51x I have just noticed you created your PR from the wrong branch and to the wrong branch.

Only use main for working on the UI code, and only open PRs to main.
I have corrected your PR by doing some Git magic, but please remember to use the main branch in the future.

@florian-h05 florian-h05 added rebuild trigger a new Jenkins job and removed rebuild trigger a new Jenkins job labels Oct 8, 2023
@florian-h05 florian-h05 added this to the 4.1 milestone Oct 8, 2023
@florian-h05 florian-h05 merged commit a1a3329 into openhab:main Oct 8, 2023
d51x added a commit to d51x/openhab-webui that referenced this pull request Oct 9, 2023
@d51x
Things list: Add grouping by location & Display location in list entr…
ad4521a 
…ies (openhab#2107)

Closes openhab#2099.

Signed-off-by: Dmitry P. (d51x) <dimonich110@gmail.com>
(cherry picked from commit a1a3329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request main ui Main UI

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

Grouping things by Loacation

2 participants

@d51x @florian-h05