Fix oh- components cannot be configured in action modals
#2094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Fixes openhab#927. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Contributor
Author
|
@ghys I have battle-tested this on my production system and I haven't noticed any regressions, so this should be safe to merge. |
Job #1159: Bundle Size — 15.78MiB (+0.11%).
Metrics (6 changes)
Total size by type (3 changes)
View job #1159 report View florian-h05:actionmodal-oh-confi... branch activity |
ghys
approved these changes
Sep 30, 2023
Member
ghys
left a comment
There was a problem hiding this comment.
Can't say I have battle-tested this myself but upon reading the code it makes sense!
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #927.
When attempting to open an
oh-Vue component, e.g.oh-colorpicker-card, as action modal, it was not possible to configure it, even thoughactionModalConfigwas set.This was because
oh-componens take their configuration from the computedconfigof the widget-mixin instead of the Vue componentprops.This PR fixes that by using the
actionModalConfigfor the computedconfigofoh-components in action modals.