这是indexloc提供的服务，不要输入任何密码
Skip to content

[BasicUI] Add support for icons based on conditional rules #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2023
Merged

[BasicUI] Add support for icons based on conditional rules #2020

merged 1 commit into from
Oct 26, 2023

Conversation

@lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Aug 14, 2023 •
edited
Loading

Depends on openhab/openhab-core#3820 and #1998

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo added enhancement New feature or request basic ui Basic UI awaiting other PR Depends on another PR labels Aug 14, 2023
@lolodomo lolodomo requested a review from a team as a code owner August 14, 2023 21:35
@lolodomo lolodomo marked this pull request as draft August 14, 2023 21:35
@lolodomo lolodomo force-pushed the basicui_dynamicIcon branch 3 times, most recently from 2083ed0 to 66175a5 Compare August 15, 2023 00:56
@lolodomo lolodomo force-pushed the basicui_dynamicIcon branch from e59b535 to 5ce5814 Compare September 9, 2023 11:59
@lolodomo lolodomo force-pushed the basicui_dynamicIcon branch 3 times, most recently from 9b16223 to c08c957 Compare October 7, 2023 12:47
@lolodomo
[BasicUI] Add support for icons based on conditional rules
dce01bf 
Depends on openhab/openhab-core#3820 and openhab#1998

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo force-pushed the basicui_dynamicIcon branch from c08c957 to dce01bf Compare October 7, 2023 13:12
@lolodomo lolodomo marked this pull request as ready for review October 7, 2023 13:14
@lolodomo
Copy link
Contributor Author

lolodomo commented Oct 7, 2023

This is now ready, fully tested with all possible transitions between icon sources.

@lolodomo lolodomo added rebuild trigger a new Jenkins job and removed awaiting other PR Depends on another PR rebuild trigger a new Jenkins job labels Oct 16, 2023
@lolodomo lolodomo mentioned this pull request Oct 22, 2023
Closed
4 tasks
kaikreuzer
kaikreuzer approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit d34f93a into openhab:main Oct 26, 2023
@kaikreuzer kaikreuzer added this to the 4.1 milestone Oct 26, 2023
@lolodomo lolodomo deleted the basicui_dynamicIcon branch October 26, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees

No one assigned

Labels

basic ui Basic UI enhancement New feature or request

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

2 participants

@lolodomo @kaikreuzer