这是indexloc提供的服务，不要输入任何密码
Skip to content

[enocean] Fix humidity and temperature readings for EEP family A5_10 #15506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 28, 2023
Merged

[enocean] Fix humidity and temperature readings for EEP family A5_10 #15506

merged 4 commits into from
Aug 28, 2023

Conversation

@fruggy83
Copy link
Contributor

@fruggy83 fruggy83 commented Aug 26, 2023

  • Updated A5-10 EEP family (corrected readings, added new channels)
  • Changed fanSpeedStage channel to type Number and added new options to it
  • Added dayNightModeState channel

fixes #15458

Signed-off-by: Daniel Weber uni@fruggy.de

@fruggy83
[enocean] Humidity and temperature readings for EEP A5_10
a15ffb4 
* Updated A5-10 EEP family (corrected readings, added new channels)
 * Changed fanSpeedStage channel to type Number and added new options to it
 * Added dayNightModeState channel

fixes openhab#15458

Signed-off-by: Daniel Weber <uni@fruggy.de>
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Aug 26, 2023
@fruggy83 fruggy83 added the work in progress A PR that is not yet ready to be merged label Aug 26, 2023
jlaur
jlaur requested changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements! Only issue found is lack of I18N regeneration - see https://www.openhab.org/docs/developer/utils/i18n.html#generating-i18n-properties-file

@fruggy83
[enocean] Humidity and temperature readings for EEP A5_10
043e1ec 
* Added I8N for new props
* Removed some magic numbers

fixes openhab#15458

Signed-off-by: Daniel Weber <uni@fruggy.de>
@fruggy83 fruggy83 removed the work in progress A PR that is not yet ready to be merged label Aug 26, 2023
@fruggy83
Copy link
Contributor Author

fruggy83 commented Aug 26, 2023

@jlaur Thanks for the hint, I updated the I8N file and added the command to my build pipeline.

jlaur
jlaur requested changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions added. If accepted, they may apply to other classes as well.

@fruggy83
[enocean] Humidity and temperature readings for EEP A5_10
19ed4be 
* Simplified/generalized the temperature calculation and added some descriptions
* Added a scaling helper

fixes openhab#15458

Signed-off-by: Daniel Weber <uni@fruggy.de>
jlaur
jlaur requested changes Aug 27, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional refactoring/improvements. I have added some minor comments about the Javadoc headers.

@fruggy83
[enocean] Humidity and temperature readings for EEP A5_10
60b5da4 
* Changed position of additional comment

fixes openhab#15458

Signed-off-by: Daniel Weber <uni@fruggy.de>
jlaur
jlaur approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur changed the title [enocean] Correct Humidity and temperature readings for EEP family A5_10 [enocean] Correct humidity and temperature readings for EEP family A5_10 Aug 28, 2023
@jlaur jlaur changed the title [enocean] Correct humidity and temperature readings for EEP family A5_10 [enocean] Fix humidity and temperature readings for EEP family A5_10 Aug 28, 2023
@jlaur jlaur merged commit b9b9bbb into openhab:main Aug 28, 2023
@jlaur jlaur added this to the 4.1 milestone Aug 28, 2023
@diRk262
Copy link

diRk262 commented Aug 31, 2023

@jlaur
Are these merged changes already available in snapshot version 4.1 of this binding?
If yes I update my binding to this version to test the changes:
https://openhab.jfrog.io/artifactory/libs-snapshot/org/openhab/addons/bundles/org.openhab.binding.enocean/4.1.0-SNAPSHOT/org.openhab.binding.enocean-4.1.0-20230830.032508-32.jar

@jlaur
Copy link
Contributor

jlaur commented Aug 31, 2023

Are these merged changes already available in snapshot version 4.1 of this binding?

Yes. Please be aware that it will only work with openHAB 4.1 snapshot version.

@diRk262
Copy link

diRk262 commented Aug 31, 2023

Are these merged changes already available in snapshot version 4.1 of this binding?

Yes. Please be aware that it will only work with openHAB 4.1 snapshot version.

Ok, I updated my system to 4.1 snapshot and the temperature and humidity readings are now correct again.
Thank you and @fruggy83 for your work!

Screenshot_20230831_223236_openHAB

@fruggy83
Copy link
Contributor Author

fruggy83 commented Aug 31, 2023

@diRk262 Thanks a lot for your test 👍

@openhab-bot
Copy link
Collaborator

openhab-bot commented Aug 31, 2023

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/enocean-humidity-and-temperature-readings-incorrect-in-4-0-2/148864/7

Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Sep 29, 2023
@fruggy83 @Pshatsillo
[enocean] Fix humidity and temperature readings for EEP family A5_10 (o…
62396bc 
…penhab#15506)

* Updated A5-10 EEP family (corrected readings, added new channels)
 * Changed fanSpeedStage channel to type Number and added new options to it
 * Added dayNightModeState channel

Fixes openhab#15458

Signed-off-by: Daniel Weber <uni@fruggy.de>
@openhab-bot
Copy link
Collaborator

openhab-bot commented Dec 21, 2023

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/beginners-guide-for-implementing-eltako-fsr14-fsb14-fud14-via-fgw14/136872/29

austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@fruggy83 @austvik
[enocean] Fix humidity and temperature readings for EEP family A5_10 (o…
0a52798 
…penhab#15506)

* Updated A5-10 EEP family (corrected readings, added new channels)
 * Changed fanSpeedStage channel to type Number and added new options to it
 * Added dayNightModeState channel

Fixes openhab#15458

Signed-off-by: Daniel Weber <uni@fruggy.de>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlaur jlaur jlaur approved these changes

Assignees

No one assigned

Labels

enhancement An enhancement or new feature for an existing add-on

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

[Enocean] Humidity and temperature readings incorrect in 4.0.2

4 participants

@fruggy83 @diRk262 @jlaur @openhab-bot