[LCN] Fixes problems with fingerprint codes which were received in decimal #15488
Conversation
…instead of hex Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de>
Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de>
fwolter
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Could you add a test case checking the new pattern? https://github.com/openhab/openhab-addons/tree/main/bundles/org.openhab.binding.lcn/src/test/java/org/openhab/binding/lcn/internal/subhandler
...g.lcn/src/main/java/org/openhab/binding/lcn/internal/subhandler/LcnModuleCodeSubHandler.java
Show resolved
Hide resolved
I can't find the right file for the test cases for the "code" subhandler. Where are the existing test cases for the other (old fingerprint) code patterns? |
|
I'm afraid there is none. I don't know why it is missing as all other subhandler do have tests... Maybe I omitted them because I don't have access to a fingerprint sensor and couldn't generate these PCK messages. Can you add a new test file? You can raise your hand if you need any help! |
Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de>
|
Done, but I have only added the required test for my edits on the code-subhandler. May someone should add the left-over code types as from UT and RT?? I think for this PR this should be not necessary. |
Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de>
…cimal (openhab#15488) * fixed problems with fingerprint codes which were received in decimal instead of hex Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> * correct format issues Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> * add test file for fingerprint codes Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> * Delete openhab-addons.code-workspace Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> --------- Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> Co-authored-by: Andre Jendrysseck <ajendry@gwdg.de>
…cimal (openhab#15488) * fixed problems with fingerprint codes which were received in decimal instead of hex Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> * correct format issues Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> * add test file for fingerprint codes Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> * Delete openhab-addons.code-workspace Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> --------- Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> Co-authored-by: Andre Jendrysseck <ajendry@gwdg.de>
…cimal (openhab#15488) * fixed problems with fingerprint codes which were received in decimal instead of hex Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> * correct format issues Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> * add test file for fingerprint codes Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> * Delete openhab-addons.code-workspace Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> --------- Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> Co-authored-by: Andre Jendrysseck <ajendry@gwdg.de> Signed-off-by: querdenker2k <querdenker2k@gmx.de>
…cimal (openhab#15488) * fixed problems with fingerprint codes which were received in decimal instead of hex Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> * correct format issues Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> * add test file for fingerprint codes Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> * Delete openhab-addons.code-workspace Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> --------- Signed-off-by: Andre Jendrysseck <ajendry@gwdg.de> Co-authored-by: Andre Jendrysseck <ajendry@gwdg.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
fingerprint codes seem also be sent in decimal (as remote control codes) by PC(H)K. The current version of the binding only accepts .ZFmmnnoo codes. This fix supports both .ZFmmnnoo or .ZFmmmnnnooo in decimal.