[chromecast] Fix STOP command #15357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
You might consider this for 4.0.2 |
Contributor
It's difficult for me to assess how safe this fix is, i.e. if we risk introducing new regressions. Do we have test confirmation from someone using the stop command? Perhaps some other @openhab/add-ons-maintainers can help assessing this risk, or by coincidence is using the binding and is able to verify? |
Contributor
Author
|
I did some testing myself, tests were successful. |
Collaborator
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/chromecast-stop-command-does-not-work-anymore/150081/4 |
Contributor
|
Test JAR from #14516 fixes the STOP command for me. OH 4.0.2, Nest Hub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14516
Split from #14159 that already had a review from @jlaur