这是indexloc提供的服务，不要输入任何密码
Skip to content

[gpstracker] Fix NumberFormatException #15337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 5, 2023
Merged

[gpstracker] Fix NumberFormatException #15337

merged 6 commits into from
Aug 5, 2023

Conversation

@lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Jul 30, 2023 •
edited
Loading

lsiepel added 2 commits July 30, 2023 18:19
@lsiepel
Fix NumberFormatException
869a2ae 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
Float
a2f242f 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel requested a review from gbicskei as a code owner July 30, 2023 16:24
@lsiepel lsiepel changed the title Fix NumberFormatException [gpstracker] Fix NumberFormatException Jul 30, 2023
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Jul 30, 2023
jlaur
jlaur requested changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one issue seeing this change and also added the tag for additional testing preferred.

It would be nice if you could remove this tag again and ping us after receiving user confirmation. Thanks!

@lsiepel
Address review comment
e3e71fa 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
Copy link
Contributor Author

lsiepel commented Jul 30, 2023

I found one issue seeing this change and also added the tag for additional testing preferred.

It would be nice if you could remove this tag again and ping us after receiving user confirmation. Thanks!

Will report back, thanks

@lsiepel
BigDecimal
313f3d4 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
Review comment
ab0b6ea 
Signed-off-by: lsiepel <leosiepel@gmail.com>
jlaur
jlaur approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Will await test confirmation before merging to be on the safe side. I assume the JAR is updated after latest changes.

@jlaur jlaur changed the title [gpstracker] Fix NumberFormatException [gpstracker] Fix NumberFormatException Aug 1, 2023
@lsiepel lsiepel removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Aug 5, 2023
@lsiepel
Copy link
Contributor Author

lsiepel commented Aug 5, 2023

LGTM, thanks! Will await test confirmation before merging to be on the safe side. I assume the JAR is updated after latest changes.

Tests confirmed, can be merged.

@jlaur jlaur merged commit c4d79a7 into openhab:main Aug 5, 2023
@jlaur jlaur added this to the 4.1 milestone Aug 5, 2023
jlaur pushed a commit that referenced this pull request Aug 5, 2023
@lsiepel @jlaur
[gpstracker] Fix NumberFormatException (#15337)
00c0699 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@jlaur jlaur added the backported A PR that has been cherry-picked to a patch release branch label Aug 5, 2023
@lsiepel lsiepel deleted the gpstracker-float branch August 5, 2023 21:09
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@lsiepel @austvik
[gpstracker] Fix NumberFormatException (openhab#15337)
e45706f 
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlaur jlaur jlaur approved these changes

@gbicskei gbicskei Awaiting requested review from gbicskei gbicskei is a code owner

Assignees

No one assigned

Labels

backported A PR that has been cherry-picked to a patch release branch bug An unexpected problem or unintended behavior of an add-on

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

[gpstracker] Error when location report contains float altitude value

2 participants

@lsiepel @jlaur