[jsscripting] Upgrade openhab-js to fix cached library injection #15336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was found out that a recent change to the webpack config for the library injection bundle heavily affected performance of the evaluation of the cached injection. openhab-js 4.5.1 fixes that regression and one minor bug, see https://github.com/openhab/openhab-js/blob/main/CHANGELOG.md#451.
jlaur
approved these changes
Jul 30, 2023
Contributor
jlaur
left a comment
There was a problem hiding this comment.
Thanks! Can you fix the DCO? Would you agree this should be backported to 4.0.x as a regression?
Contributor
Author
|
Is it enough to comment DCO? Signed-off-by: Florian Hotze florianh_dev@icloud.com
Yes, just give me one or two day(s) to test the SNAPSHOT before backporting this. |
Contributor
Author
|
@jlaur I've tested the fix, works great! This is ready to be backported now. |
jlaur
pushed a commit
that referenced
this pull request
Aug 2, 2023
…5336) It was found out that a recent change to the webpack config for the library injection bundle heavily affected performance of the evaluation of the cached injection. openhab-js 4.5.1 fixes that regression and one minor bug, see https://github.com/openhab/openhab-js/blob/main/CHANGELOG.md#451. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Collaborator
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/20-seconds-delay-until-js-script-gets-executed/148181/6 |
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…enhab#15336) It was found out that a recent change to the webpack config for the library injection bundle heavily affected performance of the evaluation of the cached injection. openhab-js 4.5.1 fixes that regression and one minor bug, see https://github.com/openhab/openhab-js/blob/main/CHANGELOG.md#451. Signed-off-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found out that a recent change to the webpack config for the library injection bundle heavily affected performance of the evaluation of the cached injection.
openhab-js 4.5.1 fixes that regression and one minor bug, see https://github.com/openhab/openhab-js/blob/v4.5.1/CHANGELOG.md#451.