[androidtv] Adds gtvEnabled Option #15317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
wborn
reviewed
Jul 29, 2023
...binding.androidtv/src/main/java/org/openhab/binding/androidtv/internal/AndroidTVHandler.java
Outdated
Show resolved
Hide resolved
Contributor
|
@morph166955 - two things:
|
Contributor
Author
|
I can absolutely add this to the readme. This is in preparation for adding the Phillips and Sony protocols to the binding which I'm currently working. Philips it's no longer maintained so I'm trying to integrate here both because it makes sense and to support the community going forward. Sony is maintained in a maintenance mode, and really needs to get merged in as well. I don't anticipate or encourage users to disable Google regularly. However, for testing, or to maintain backwards compatibility, the may choose to use that protocol instead. |
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
Contributor
Author
Contributor
Author
|
Is there anything else needed on this? |
lolodomo
requested changes
Jul 31, 2023
bundles/org.openhab.binding.androidtv/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
Contributor
Author
|
I'm going to have to rebase. Looks like the i18n got out of sync. |
92ecb11 to
43e60a2
Compare
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
Contributor
Author
|
That should resolve the conflict. |
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Sep 29, 2023
* Adds gtvEnabled --------- Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* Adds gtvEnabled --------- Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability on non-GoogleTV things to disable the GoogleTV protocol stack. This is in preparation for addition of new protocol stacks coming soon.