[pushover] Add support for Expiring Messages #15289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3e6455 to
b7588c3
Compare
197cb25 to
0054e6d
Compare
Contributor
Author
|
@cweitkamp - would you like to review this pull request? |
Resolves openhab#15288 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
0054e6d to
4d60aa3
Compare
lolodomo
requested changes
Oct 19, 2023
...r/src/main/java/org/openhab/binding/pushover/internal/connection/PushoverMessageBuilder.java
Show resolved
Hide resolved
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Contributor
Author
|
@lolodomo - thanks for the review. 👍 |
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 21, 2023
* Add support for Expiring Messages * Add action variants with TTL parameter Resolves openhab#15288 --------- Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 29, 2023
* Add support for Expiring Messages * Add action variants with TTL parameter Resolves openhab#15288 --------- Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* Add support for Expiring Messages * Add action variants with TTL parameter Resolves openhab#15288 --------- Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support for Expiring Messages.
I've had some doubts about what would be the best the way to expose this in the thing action API. There is currently a mix of "themed" actions with reduced signatures and a generic action with a full parameter list (where argument positions cannot be changed due to backwards compatibility). Since the TTL parameter applies to all, in the current implementation I have added it to each action as a last optional parameter.
Additionally:
sendMessageoverload withouttitleparameter.Resolves #15288