[speedtest] Add timestamp and result image channel, update thing description #15278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daMihe
requested changes
Sep 9, 2023
...binding.speedtest/src/main/java/org/openhab/binding/speedtest/internal/SpeedtestHandler.java
Outdated
Show resolved
Hide resolved
...binding.speedtest/src/main/java/org/openhab/binding/speedtest/internal/SpeedtestHandler.java
Outdated
Show resolved
Hide resolved
...binding.speedtest/src/main/java/org/openhab/binding/speedtest/internal/SpeedtestHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.speedtest/src/main/resources/OH-INF/i18n/speedtest_it.properties
Show resolved
Hide resolved
bundles/org.openhab.binding.speedtest/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.speedtest/src/main/resources/OH-INF/i18n/speedtest.properties
Show resolved
Hide resolved
Contributor
|
I‘ll do the review at the next weekend. |
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Signed-off-by: Michael Weger <weger.michael@gmx.net>
07c5372 to
7fd9911
Compare
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Contributor
Author
Thx for the review and thx for the guideline! |
Contributor
Author
|
@daMihe please have a look again and do the merge |
daMihe
approved these changes
Sep 18, 2023
Contributor
|
LGTM, i do not have the right to merge. @lolodomo What do you think? |
lolodomo
requested changes
Oct 18, 2023
...peedtest/src/main/java/org/openhab/binding/speedtest/internal/SpeedtestBindingConstants.java
Show resolved
Hide resolved
...binding.speedtest/src/main/java/org/openhab/binding/speedtest/internal/SpeedtestHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.speedtest/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.speedtest/src/main/resources/OH-INF/update/instructions.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.speedtest/src/main/resources/OH-INF/update/instructions.xml
Outdated
Show resolved
Hide resolved
...binding.speedtest/src/main/java/org/openhab/binding/speedtest/internal/SpeedtestHandler.java
Outdated
Show resolved
Hide resolved
...binding.speedtest/src/main/java/org/openhab/binding/speedtest/internal/SpeedtestHandler.java
Outdated
Show resolved
Hide resolved
...binding.speedtest/src/main/java/org/openhab/binding/speedtest/internal/SpeedtestHandler.java
Outdated
Show resolved
Hide resolved
...binding.speedtest/src/main/java/org/openhab/binding/speedtest/internal/SpeedtestHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Weger <weger.michael@gmx.net>
lolodomo
requested changes
Oct 19, 2023
....speedtest/src/main/java/org/openhab/binding/speedtest/internal/SpeedtestHandlerFactory.java
Outdated
Show resolved
Hide resolved
Contributor
|
Please test that the thing upgrade (thing created with MainUI) is working, meaning the two new channels are appearing as expected after installing the new version of the binding. Your thing must be created first with the old version of the binding. |
Signed-off-by: Michael Weger <weger.michael@gmx.net>
Contributor
Author
|
Did the test. The new channels show up without the need of re-adding the thing. |
Contributor
Excellent |
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 21, 2023
…ription (openhab#15278) * added timestamp channel, updated thing description * added resultImage --------- Signed-off-by: Michael Weger <weger.michael@gmx.net>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 29, 2023
…ription (openhab#15278) * added timestamp channel, updated thing description * added resultImage --------- Signed-off-by: Michael Weger <weger.michael@gmx.net> Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…ription (openhab#15278) * added timestamp channel, updated thing description * added resultImage --------- Signed-off-by: Michael Weger <weger.michael@gmx.net> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added timestamp and result image channel, updated thing description