[boschshc] Update active profile of intrusion detection system #15899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue that caused the active configuration profile of the intrusion detection system not to be updated. closes openhab#15848 Signed-off-by: David Pace <dev@davidpace.de>
jlaur
approved these changes
Nov 14, 2023
Contributor
jlaur
left a comment
There was a problem hiding this comment.
Thanks for the fix! I'll let @GerdZanker have a look before merging.
Contributor
|
Hi. Maybe the Channels also needs to be added in initializedService(). Line 96? just guessing, never did Binding development before |
Signed-off-by: David Pace <dev@davidpace.de>
Member
Author
|
Thanks for the hint @PLeusmann, maybe you should start developing bindings when you see stuff like that 😉 I'm marking this as work in progress for now since I would prefer to do some additional testing tomorrow. |
Member
Author
|
Tests successful, removing work in progress label. |
GerdZanker
approved these changes
Nov 20, 2023
Contributor
GerdZanker
left a comment
There was a problem hiding this comment.
looks good and thanks for your fix @david-pace
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Nov 26, 2023
…ab#15899) * [boschshc] Update active profile of intrusion detection system Fixes an issue that caused the active configuration profile of the intrusion detection system not to be updated. closes openhab#15848 * [boschshc] add channel to control state service registration Signed-off-by: David Pace <dev@davidpace.de>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…ab#15899) * [boschshc] Update active profile of intrusion detection system Fixes an issue that caused the active configuration profile of the intrusion detection system not to be updated. closes openhab#15848 * [boschshc] add channel to control state service registration Signed-off-by: David Pace <dev@davidpace.de> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue that caused the active configuration profile of the intrusion detection system not to be updated.
closes #15848