[mqtt.homeassistant] Improve Cover support #15875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/chamberlain-myq-binding/4192/1018 |
03487c1 to
ca7ef21
Compare
antroids
requested changes
Nov 13, 2023
...g.mqtt.generic/src/main/java/org/openhab/binding/mqtt/generic/values/RollershutterValue.java
Outdated
Show resolved
Hide resolved
...g.mqtt.generic/src/main/java/org/openhab/binding/mqtt/generic/values/RollershutterValue.java
Outdated
Show resolved
Hide resolved
Contributor
|
LGTM |
antroids
approved these changes
Nov 14, 2023
Contributor
|
Please note there is a conflicting file. |
* Add support for covers that report position * Handle when command and state values for OPEN/CLOSE/STOP differ (as they do by default) * Expose the full cover state, since it can have tell you if the cover is moving or not * Handle covers that have a position only, but not a state Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
it was unnecessary Signed-off-by: Cody Cutrer <cody@cutrer.us>
157202c to
0e68254
Compare
Contributor
Author
|
Rebased and resolved trivial merge conflict (#15427 modified a line that this PR completely changed anyway). |
Contributor
Author
|
Anything pending before this can be merged? |
Contributor
Author
|
@lolodomo : I'd love to get this one merged. It's the last piece needed so that the ratgdo ESPHome build works well with openHAB, which is shaping up to be a popular replacement for MyQ. See the last several (hundred?) posts in https://community.openhab.org/t/chamberlain-myq-binding/4192. |
lolodomo
reviewed
Dec 10, 2023
...assistant/src/main/java/org/openhab/binding/mqtt/homeassistant/internal/component/Cover.java
Show resolved
Hide resolved
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* [mqtt.homeassistant] improve Cover support * Add support for covers that report position * Handle when command and state values for OPEN/CLOSE/STOP differ (as they do by default) * Expose the full cover state, since it can have tell you if the cover is moving or not * Handle covers that have a position only, but not a state * add constants to clarify up/down values * Be sure to parse percents from strings in RollshutterValue --------- Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* [mqtt.homeassistant] improve Cover support * Add support for covers that report position * Handle when command and state values for OPEN/CLOSE/STOP differ (as they do by default) * Expose the full cover state, since it can have tell you if the cover is moving or not * Handle covers that have a position only, but not a state * add constants to clarify up/down values * Be sure to parse percents from strings in RollshutterValue --------- Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15845