[androiddebugbridge] Reconnect on max timeouts and improve volume channel #15788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnel Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
dac7986 to
44d8dac
Compare
lsiepel
requested changes
Oct 22, 2023
Contributor
lsiepel
left a comment
There was a problem hiding this comment.
LGTM. Could you also update update the readme.md with these changes?
Member
Author
|
Sure, I totally forgot, and thank you for the review! |
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
lsiepel
approved these changes
Oct 22, 2023
lolodomo
requested changes
Nov 3, 2023
...in/java/org/openhab/binding/androiddebugbridge/internal/AndroidDebugBridgeConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Member
Author
|
I think the pipeline has failed due a small GitHub downtime. |
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Nov 26, 2023
…nnel (openhab#15788) * [androiddebugbridge] Reconnect on max timeouts and improve volume channel --------- Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…nnel (openhab#15788) * [androiddebugbridge] Reconnect on max timeouts and improve volume channel --------- Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR introduces an option to reset the adb connection after a configurable number of consecutive timeouts. It seems to solve an issue I was occasionally having after letting the device (Chomecast with Google TV) sleeping for a while.
Also adds support for the INCREASE and DECREASE command to the volume channel which were incorrectly handled before.
I have also moved the load of the adb keys from the static context to the activate method of the thing handler.
Hope everything is in place, best regards.