这是indexloc提供的服务，不要输入任何密码
Skip to content

[tesla] Fix update timestamp and null exception for offline state #15756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2023
Merged

[tesla] Fix update timestamp and null exception for offline state #15756

merged 1 commit into from
Oct 17, 2023

Conversation

@billfor
Copy link
Contributor

@billfor billfor commented Oct 14, 2023

Description

  • Fix the update channel.
  • Fix a NULL exception caused by attempted poll when vehicle is offline.

@billfor billfor added the bug An unexpected problem or unintended behavior of an add-on label Oct 14, 2023
@billfor billfor requested a review from kaikreuzer October 14, 2023 19:34
@billfor billfor requested a review from kgoderis as a code owner October 14, 2023 19:34
@jlaur jlaur linked an issue Oct 15, 2023 that may be closed by this pull request
[tesla] Some channels are broken #14967
Closed
lolodomo
lolodomo approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

lolodomo commented Oct 16, 2023

I am not sure @kgoderis is still really active here. Maybe @kaikreuzer you would like to validate ?

@kgoderis
Copy link
Contributor

kgoderis commented Oct 16, 2023 via email

kaikreuzer
kaikreuzer approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 118afa3 into openhab:main Oct 17, 2023
@kaikreuzer kaikreuzer added this to the 4.1 milestone Oct 17, 2023
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
@billfor @querdenker2k
[tesla] Fix update timestamp and null exception for offline state (op…
33986c3 
…enhab#15756)

Signed-off-by: Bill Forsyth <git@billforsyth.net>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
@billfor @querdenker2k
[tesla] Fix update timestamp and null exception for offline state (op…
3069da7 
…enhab#15756)

Signed-off-by: Bill Forsyth <git@billforsyth.net>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
@billfor billfor deleted the teslatimestampfix branch November 5, 2023 04:31
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@billfor @austvik
[tesla] Fix update timestamp and null exception for offline state (op…
dbbd4a6 
…enhab#15756)

Signed-off-by: Bill Forsyth <git@billforsyth.net>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@lolodomo lolodomo lolodomo approved these changes

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

Assignees

No one assigned

Labels

bug An unexpected problem or unintended behavior of an add-on

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

[tesla] Some channels are broken

4 participants

@billfor @lolodomo @kgoderis @kaikreuzer