[paradoxalarm] Implement zone bypass command and additional zone states #14557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
* Added the checksum functionality * Added more examples to the test Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
* Refactor the common logic * Extract interface Command * CHange the Response class to use Switch/case Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
* Fix checksum creation * Fix the parse and confirmation of the response Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
* A silly copy/paste mistake Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
As per community discussion this makes more sense and will be more intuitive - when something is true -> make it ON, when it's false -> make it OFF. OPEN and CLOSED are not fitting so well here... Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
* For both zone and partitions Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
Contributor
Author
|
I wonder if someone could have a look at this PR? It looks like a lot of changes but not really... Just one feature added and some refactoring to fit better the new feature... |
Contributor
Author
|
@openhab/add-ons-maintainers Could someone have a look at the PR? I'd like to merge it sooner or later and it's pending for a lot of time. Also there is subsequent PR that's waiting a review together with this one and optimally if these two get merged, I would like to invest a little bit to remove all (as much as possible) of the warnings. Thanks in advance, |
fwolter
requested changes
Jun 20, 2023
Member
fwolter
left a comment
There was a problem hiding this comment.
You could run mvn org.openhab.core.tools:i18n-maven-plugin:3.4.0:generate-default-translations to update the i18n properties file to make the newly added channels available in Crowdin for translation.
Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
c8372d8 to
980f27f
Compare
Contributor
Author
|
@fwolter Hi Fabian, I wonder if you could continue with the review so we can merge this PR? I already did the requested change a few weeks back... |
Collaborator
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/paradox-evo-alarm-binding-using-ip150/148931/14 |
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Sep 29, 2023
…es (openhab#14557) * Reduce warnings 1 Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * 2 Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * 3 Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Initial files and package refactoring Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Implemented zone commands without checksum calculation Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * More stuff * Added the checksum functionality * Added more examples to the test Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Implement ZoneCommand and necessary classes * Refactor the common logic * Extract interface Command * CHange the Response class to use Switch/case Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Fully implement the test for creating zone command payload Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Fix build / add headers and author to the new files Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Add command handling to the zone handler Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Add command channel to the Zone thing Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Research of zone states and some TODO notes Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Retrieval of zone special states from the panel Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Fix build Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Add the new channels to the metadata file Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Add new channels to zone handler Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Fix indexing in memory map and add more logging Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Refactoring and potential NPE access fixes Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Add new property "label" to the discovered zones and partitions Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Fix zone command issues * Fix checksum creation * Fix the parse and confirmation of the response Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Add the new channels to the README.md Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Fixed issue with not updating new channels in the zones * A silly copy/paste mistake Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Change the type of the new channels from contact to switch As per community discussion this makes more sense and will be more intuitive - when something is true -> make it ON, when it's false -> make it OFF. OPEN and CLOSED are not fitting so well here... Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Fix issue that the channel label is always NULL * For both zone and partitions Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Add new types and channels to the i18n Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> --------- Signed-off-by: Konstantin Polihronov <polychronov@gmail.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…es (openhab#14557) * Reduce warnings 1 Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * 2 Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * 3 Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Initial files and package refactoring Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Implemented zone commands without checksum calculation Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * More stuff * Added the checksum functionality * Added more examples to the test Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Implement ZoneCommand and necessary classes * Refactor the common logic * Extract interface Command * CHange the Response class to use Switch/case Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Fully implement the test for creating zone command payload Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Fix build / add headers and author to the new files Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Add command handling to the zone handler Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Add command channel to the Zone thing Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Research of zone states and some TODO notes Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Retrieval of zone special states from the panel Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Fix build Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Add the new channels to the metadata file Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Add new channels to zone handler Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Fix indexing in memory map and add more logging Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Refactoring and potential NPE access fixes Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Add new property "label" to the discovered zones and partitions Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Fix zone command issues * Fix checksum creation * Fix the parse and confirmation of the response Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Add the new channels to the README.md Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Fixed issue with not updating new channels in the zones * A silly copy/paste mistake Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Change the type of the new channels from contact to switch As per community discussion this makes more sense and will be more intuitive - when something is true -> make it ON, when it's false -> make it OFF. OPEN and CLOSED are not fitting so well here... Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Fix issue that the channel label is always NULL * For both zone and partitions Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> * Add new types and channels to the i18n Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> --------- Signed-off-by: Konstantin Polihronov <polychronov@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a request from a member of the community to implement a zone bypass functionality from within the OpenHAB. Has been tested by me and the customer. Additionally I enhanced a bit the unit tests.