这是indexloc提供的服务，不要输入任何密码
Skip to content

[gpio] Set UP value on startup when inverted #13376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[gpio] Set UP value on startup when inverted #13376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...o/src/main/java/org/openhab/binding/gpio/internal/handler/PigpioDigitalOutputHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ public PigpioDigitalOutputHandler(GPIOOutputConfiguration configuration, JPigpio
throw new NoGpioIdException();
}
this.gpio = new GPIO(jPigpio, gpioId, JPigpio.PI_OUTPUT);
if (configuration.invert) {
updateStatus.accept(OnOffType.ON);
Copy link
Contributor

@SloCompTech SloCompTech Sep 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this line be added ? Because inverted means that pin should be by default in state 1, but this means OFF not ON, because it is inverted .

Copy link
Author

@msteiger msteiger Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'm not sure on this on either. Maybe not setting updateStatus would be the correct thing to do. What do you think @nils-bauer ?

Copy link
Contributor

@lsiepel lsiepel Mar 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As 6 months have passsed, is this properly addressed ?

Copy link
Author

@msteiger msteiger Mar 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping that this entire PR could be replaced with #13643 and still keep my fingers crossed that it will be merged over the next days.

gpio.setValue(true);
}
}

@Override
Expand Down