[GPIO] Update GPIO binding to fix issues and provide new functionality #13643

jeremyrumpf · 2022-11-02T01:36:05Z

Attempting to improve the reliability and usefulness of the GPIO binding in OpenHAB

Add the ability to recover from network disconnects to pigpiod.
Provide actions to what the binding does on pigpiod connect/disconnect/reconnect.
Provide the ability to pulse outputs in a one-shot/momentary fashion.
Provide edge mode configuration for gpio outputs.

This should provide a workaround for #11039 by allowing the user to configure the output channels to refresh/sync their channel state with pigpiod upon connect/reconnect.

#11038 is corrected. The binding now polls the remote pigpiod instance to determine connectivity and reconnects on connection loss.

This should also provide the same corrective action as PR #13376

Fixes #11038

lolodomo · 2022-11-03T08:08:12Z

PR does not compile and is not properly signed.

jeremyrumpf · 2022-11-03T13:05:25Z

Unfortunately, my main programming language is not Java. I'm fighting with the Null annotations. It compiles without warning on my Centos 8 environment with openjdk 11.0.15 2022-04-19 LTS, but does not in your environment. I have to figure out what the differences are. Regards, Jeremy

…

On Thu, Nov 3, 2022 at 4:08 AM lolodomo ***@***.***> wrote: PR does not compile and is not properly signed. — Reply to this email directly, view it on GitHub <#13643 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATUYTTPR5EFCZKDKERAHTGLWGNXHNANCNFSM6AAAAAARUTDWIY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

lolodomo · 2022-11-05T16:02:56Z

The PR is now building. But not yet properly signed off.

…ality. * Add the ability to recover from network disconnects to pigpiod. * Provide actions to what the binding does on pigpiod connect/disconnect/reconnect. * Provide the ability to pulse outputs in a one-shot/momentary fashion. * Provide edge level configuration for gpio outputs. Workaround: openhab#11039 Fixes: openhab#11038 Fixes: openhab#13376 Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

Signed-Off-By: Jeremy Rumpf <rumpf.99@gmail.com> Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

bundles/org.openhab.binding.gpio/README.md

lsiepel

Minor typo and codestyle. looks good

lsiepel · 2022-12-22T20:17:19Z

...inding.gpio/src/main/java/org/openhab/binding/gpio/internal/handler/PigpioRemoteHandler.java

+    }
+
+    protected void setChannelJPigpio(@Nullable JPigpio jPigpio) throws PigpioException {
+        if (this.channelHandlers.isEmpty())


minor checkstyle, please add braces

...inding.gpio/src/main/java/org/openhab/binding/gpio/internal/handler/PigpioRemoteHandler.java

Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

…nHAB. Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

…ut. Attempt to clarify plurals. Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

conflicts. Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

msteiger · 2023-02-19T14:45:19Z

Can we merge this one?

lsiepel

Thanks for the PR. I left some questions and some suggestions. Mainly logging and style.
Please don't forget to run the mvn i18n:generate-default-translations

bundles/org.openhab.binding.gpio/README.md

....gpio/src/main/java/org/openhab/binding/gpio/internal/handler/PigpioDigitalInputHandler.java

...io/src/main/java/org/openhab/binding/gpio/internal/configuration/GPIOInputConfiguration.java

jlaur

Thanks for the fixes and improvements. In addition to @lsiepel's comments I have added a few minor ones.

bundles/org.openhab.binding.gpio/README.md

Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

msteiger · 2023-04-28T08:50:59Z

Hi, any news here? Can I help?

… main

Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

jlaur

I have provided some additional feedback after going through changed files, since I didn't remember how I left it in last iteration. I think this can be merged soon, but especially the formatting of the documentation looks strange, so it would be nice if you could have a look here.

bundles/org.openhab.binding.gpio/README.md

....gpio/src/main/java/org/openhab/binding/gpio/internal/handler/PigpioDigitalInputHandler.java

...inding.gpio/src/main/java/org/openhab/binding/gpio/internal/handler/PigpioRemoteHandler.java

lsiepel · 2023-08-25T21:22:23Z

Gentle ping @jeremyrumpf hope you can address the last review comments so this can be merged?

msteiger · 2023-10-29T12:45:40Z

It would be really great to get this one merged. Anything I can do to help?

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

lsiepel · 2023-10-29T14:39:08Z

As the requested changes are mainly documentation layout and logging related, i took the oppertunity to add some commits and address these. @jeremyrumpf i hope you are okay with that.
Hopefully we can proceed merging this.

bundles/org.openhab.binding.gpio/README.md

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

jeremyrumpf · 2023-10-29T23:14:52Z

As the requested changes are mainly documentation layout and logging related, i took the oppertunity to add some commits and address these. @jeremyrumpf i hope you are okay with that. Hopefully we can proceed merging this.

I believe they were mostly formatting related. I'm not most creative using markdown, so anything you think is appropriate will be welcome. The two logging level messages can be moved to debug. I do not really have a preference, if that is more inline with OpenHAB's best practices.

If there's anything else you need, let me know.

lsiepel · 2023-10-30T15:53:44Z

As the requested changes are mainly documentation layout and logging related, i took the oppertunity to add some commits and address these. @jeremyrumpf i hope you are okay with that. Hopefully we can proceed merging this.

I believe they were mostly formatting related. I'm not most creative using markdown, so anything you think is appropriate will be welcome. The two logging level messages can be moved to debug. I do not really have a preference, if that is more inline with OpenHAB's best practices.

If there's anything else you need, let me know.

In that case this PR is ready to be merged from my perspective

jlaur

LGTM. @jeremyrumpf - thanks for your contribution, and thank you @lsiepel for helping getting this to the finish line.

openhab#13643) * [GPIO] Update the GPIO binding to fix issues and provide new functionality. * Add the ability to recover from network disconnects to pigpiod. * Provide actions to what the binding does on pigpiod connect/disconnect/reconnect. * Provide the ability to pulse outputs in a one-shot/momentary fashion. * Provide edge level configuration for gpio outputs. * Fix automated style checks. * Attempt to squash jenkins build warnings/errors. * Correct Null annotations and adjust log levels in certain areas. * Fix bracing per checkstyle review. * Normalize gpiod/pigpiod to pigpiod. openhab/openHAB normalized to OpenHAB. * Fix a copy/paste error. Output channels should not be referred as input. Attempt to clarify plurals. * Convert strings to defined constants. * Convert pulse command strings to binding constants. * Java17 instanceof pattern matching. * Nit, fix missed pulse command string to binding constant. * Add missing quotes in demo.things file definition. Workaround openhab#11039 Fixes openhab#11038 Fixes openhab#13376 Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

openhab#13643) * [GPIO] Update the GPIO binding to fix issues and provide new functionality. * Add the ability to recover from network disconnects to pigpiod. * Provide actions to what the binding does on pigpiod connect/disconnect/reconnect. * Provide the ability to pulse outputs in a one-shot/momentary fashion. * Provide edge level configuration for gpio outputs. * Fix automated style checks. * Attempt to squash jenkins build warnings/errors. * Correct Null annotations and adjust log levels in certain areas. * Fix bracing per checkstyle review. * Normalize gpiod/pigpiod to pigpiod. openhab/openHAB normalized to OpenHAB. * Fix a copy/paste error. Output channels should not be referred as input. Attempt to clarify plurals. * Convert strings to defined constants. * Convert pulse command strings to binding constants. * Java17 instanceof pattern matching. * Nit, fix missed pulse command string to binding constant. * Add missing quotes in demo.things file definition. Workaround openhab#11039 Fixes openhab#11038 Fixes openhab#13376 Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>

jeremyrumpf requested a review from nils-bauer as a code owner November 2, 2022 01:36

lolodomo added invalid and removed invalid labels Nov 5, 2022

Jeremy Rumpf and others added 5 commits November 5, 2022 12:03

Small documentation nits.

a913e60

Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

Fix automated style checks.

bb4af17

Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

Attempt to squash jenkins build warnings/errors.

50b612d

Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

Correct Null annotations and adjust log levels in certain areas.

fece6c8

Signed-Off-By: Jeremy Rumpf <rumpf.99@gmail.com> Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

jeremyrumpf force-pushed the main branch from ab734f9 to fece6c8 Compare November 5, 2022 16:04

wborn added the enhancement An enhancement or new feature for an existing add-on label Nov 5, 2022

jeremyrumpf mentioned this pull request Dec 21, 2022

[gpio] Set UP value on startup when inverted #13376

Closed

Merge branch 'main' into main

0f95b56

lsiepel reviewed Dec 22, 2022

View reviewed changes

bundles/org.openhab.binding.gpio/README.md Outdated Show resolved Hide resolved

lsiepel reviewed Dec 22, 2022

View reviewed changes

Fix bracing per checkstyle review.

3ab5661

Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

jeremyrumpf force-pushed the main branch from aee15d2 to 3ab5661 Compare December 26, 2022 22:57

jeremyrumpf added 3 commits December 26, 2022 18:23

Normalize gpiod/pigpiod to pigpiod. openhab/openHAB normalized to Ope…

9d4b424

…nHAB. Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

Fix a copy/paste error. Output channels should not be referred as inp…

a9da43f

…ut. Attempt to clarify plurals. Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

Merge remote-tracking branch 'upstream/main' into main. Resolved

0ec38f0

conflicts. Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

jeremyrumpf requested a review from a team as a code owner January 19, 2023 21:57

Remove accidental checkin of rsync.sh

6aed1e7

Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

Hilbrand requested a review from lsiepel February 20, 2023 12:30

lsiepel requested changes Feb 24, 2023

View reviewed changes

jlaur requested changes Mar 9, 2023

View reviewed changes

bundles/org.openhab.binding.gpio/README.md Outdated Show resolved Hide resolved

bundles/org.openhab.binding.gpio/README.md Outdated Show resolved Hide resolved

bundles/org.openhab.binding.gpio/README.md Outdated Show resolved Hide resolved

jeremyrumpf added 2 commits March 26, 2023 14:49

Merge remote-tracking branch 'upstream/main' into main

6b08a5b

README suggestions from lsiepel.

b1c11a1

Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

jeremyrumpf added 2 commits April 30, 2023 19:52

Merge branch 'main' of https://github.com/openhab/openhab-addons into…

b932754

… main

Fix README code fences.

291f90b

Signed-off-by: Jeremy Rumpf <rumpf.99@gmail.com>

jlaur requested changes May 2, 2023

View reviewed changes

jlaur added the awaiting feedback Awaiting feedback from the pull request author label Jul 13, 2023

lsiepel added 4 commits October 29, 2023 15:17

Review comments

cdb532d

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

Fix readme linting

466db83

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

mroe readnme fixes

79d7394

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

missed logger

f51f99a

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

lsiepel removed the awaiting feedback Awaiting feedback from the pull request author label Oct 29, 2023

lsiepel requested a review from jlaur October 29, 2023 14:39

jlaur reviewed Oct 29, 2023

View reviewed changes

bundles/org.openhab.binding.gpio/README.md Outdated Show resolved Hide resolved

jlaur reviewed Oct 29, 2023

View reviewed changes

bundles/org.openhab.binding.gpio/README.md Outdated Show resolved Hide resolved

jlaur reviewed Oct 29, 2023

View reviewed changes

bundles/org.openhab.binding.gpio/README.md Outdated Show resolved Hide resolved

jlaur reviewed Oct 29, 2023

View reviewed changes

bundles/org.openhab.binding.gpio/README.md Outdated Show resolved Hide resolved

jlaur reviewed Oct 29, 2023

View reviewed changes

bundles/org.openhab.binding.gpio/README.md Outdated Show resolved Hide resolved

Remaining readme comments

a8de07d

Signed-off-by: Leo Siepel <leosiepel@gmail.com>

lsiepel requested a review from jlaur October 29, 2023 16:23

jlaur approved these changes Oct 30, 2023

View reviewed changes

jlaur merged commit b24f3a2 into openhab:main Oct 30, 2023

jlaur added this to the 4.1 milestone Oct 30, 2023

This was referenced Oct 30, 2023

[gpio] Invalid state of output channel after reboot #11296

Closed

[gpio] gpio state is cycled and set to opposite of default when thing is enabled #11039

Closed

Uh oh!

[GPIO] Update GPIO binding to fix issues and provide new functionality #13643

[GPIO] Update GPIO binding to fix issues and provide new functionality #13643

Uh oh!

Conversation

jeremyrumpf commented Nov 2, 2022 • edited by jlaur Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lolodomo commented Nov 3, 2022

Uh oh!

jeremyrumpf commented Nov 3, 2022 via email

Uh oh!

lolodomo commented Nov 5, 2022

Uh oh!

Uh oh!

lsiepel left a comment

Choose a reason for hiding this comment

Uh oh!

lsiepel Dec 22, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

msteiger commented Feb 19, 2023

Uh oh!

lsiepel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jlaur left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msteiger commented Apr 28, 2023

Uh oh!

jlaur left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lsiepel commented Aug 25, 2023

Uh oh!

msteiger commented Oct 29, 2023

Uh oh!

lsiepel commented Oct 29, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeremyrumpf commented Oct 29, 2023

Uh oh!

lsiepel commented Oct 30, 2023

Uh oh!

jlaur left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

jeremyrumpf commented Nov 2, 2022 •

edited by jlaur

Loading