这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Dec 27, 2023

since #13801, it's not been possible to add new milight things, because the thing XML already has the new channel types, but not the thingTypeVersion property set, so it would try to apply the update instructions and error about duplicate channels

since openhab#13801, it's not been possible to add new milight things,
because the thing XML already has the new channel types, but not
the thingTypeVersion property set, so it would try to apply the
update instructions and error about duplicate channels

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer requested a review from lolodomo December 27, 2023 23:13
@ccutrer ccutrer requested a review from Skinah as a code owner December 27, 2023 23:13
@ccutrer
Copy link
Contributor Author

ccutrer commented Dec 27, 2023

@lolodomo @jlaur: this should also be applied to the 4.1.x branch, since it's a regression in 4.1.0

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit e81550f into openhab:main Dec 27, 2023
@jlaur jlaur added this to the 4.2 milestone Dec 27, 2023
jlaur pushed a commit that referenced this pull request Dec 27, 2023
since #13801, it's not been possible to add new milight things,
because the thing XML already has the new channel types, but not
the thingTypeVersion property set, so it would try to apply the
update instructions and error about duplicate channels

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@jlaur jlaur added backported A PR that has been cherry-picked to a patch release branch bug An unexpected problem or unintended behavior of an add-on labels Dec 27, 2023
@jlaur jlaur changed the title [mqtt.espmilighthub] fix upgrade instructions [mqtt.espmilighthub] Fix upgrade instructions Dec 27, 2023
@ccutrer ccutrer deleted the mqtt-espmilightub-thing-type-version branch December 28, 2023 14:51
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
since openhab#13801, it's not been possible to add new milight things,
because the thing XML already has the new channel types, but not
the thingTypeVersion property set, so it would try to apply the
update instructions and error about duplicate channels

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
since openhab#13801, it's not been possible to add new milight things,
because the thing XML already has the new channel types, but not
the thingTypeVersion property set, so it would try to apply the
update instructions and error about duplicate channels

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported A PR that has been cherry-picked to a patch release branch bug An unexpected problem or unintended behavior of an add-on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants