这是indexloc提供的服务，不要输入任何密码
Skip to content

[surepetcare] Fix DateTimeParseException #16087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2023
Merged

[surepetcare] Fix DateTimeParseException #16087

merged 1 commit into from
Dec 20, 2023

Conversation

@jlaur
Copy link
Contributor

@jlaur jlaur commented Dec 20, 2023 •
edited
Loading

@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Dec 20, 2023
@jlaur jlaur requested a review from renescherer as a code owner December 20, 2023 15:13
@jlaur jlaur requested a review from a team December 20, 2023 15:57
@jlaur jlaur force-pushed the 16082-surepetcare-datetimeparseexception branch from 0bf3f01 to 3a0f92c Compare December 20, 2023 16:32
@jlaur
Fix DateTimeParseException
a350723 
Fixes openhab#16082

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur force-pushed the 16082-surepetcare-datetimeparseexception branch from 3a0f92c to a350723 Compare December 20, 2023 17:19
J-N-K
J-N-K approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In general it would be nice to have a test that shows that an invalid date results in a JsonarseException.

@J-N-K J-N-K added this to the 4.1 milestone Dec 20, 2023
@J-N-K J-N-K merged commit 0055ce3 into openhab:main Dec 20, 2023
@jlaur jlaur deleted the 16082-surepetcare-datetimeparseexception branch December 21, 2023 13:57
jlaur added a commit that referenced this pull request Dec 22, 2023
@jlaur
[surepetcare] Fix DateTimeParseException (#16087)
94d110a 
Fixes #16082

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the backported A PR that has been cherry-picked to a patch release branch label Dec 22, 2023
@pgfeller
Copy link
Contributor

pgfeller commented Dec 22, 2023 •
edited
Loading

HI @jlaur,

I've tested the latest 4.1 jar with openHAB 4.1.0 - Build 3799; login and discovery works as expected 👍 ... cool that you added the patch to the 4.0 branch as well. The binding is working with 4.0.4 as well 👍

many thanks and with kind regards,
Patrik

@jlaur
Copy link
Contributor Author

jlaur commented Dec 22, 2023

I've tested the latest 4.1 jar with openHAB 4.1.0 - Build 3799; login and discovery works as expected 👍

Thanks for confirming that the fix works as expected. I had to take a chance with 4.1 since we reached code freeze, but unit tests helped reducing the risk.

cool that you added the patch to the 4.0 branch as well. The binding is working with 4.0.4 as well 👍

You're welcome. I don't know if there will be further 4.0.x releases, but at least the JAR is now available.

austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@jlaur @austvik
[surepetcare] Fix DateTimeParseException (openhab#16087)
d258973 
Fixes openhab#16082

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@jlaur @joni1993
[surepetcare] Fix DateTimeParseException (openhab#16087)
e446d31 
Fixes openhab#16082

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@J-N-K J-N-K J-N-K approved these changes

@renescherer renescherer renescherer approved these changes

Assignees

No one assigned

Labels

additional testing preferred The change works for the pull request author. A test from someone else is preferred though. backported A PR that has been cherry-picked to a patch release branch bug An unexpected problem or unintended behavior of an add-on

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

[surepetcare] - API change ➡️ HANDLER_INITIALIZING_ERROR

4 participants

@jlaur @pgfeller @J-N-K @renescherer