-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[tesla] Fix "jumping" location updates #16032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kai Kreuzer <kai@openhab.org>
lolodomo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
|
great thanks! |
Fix is included in 4.1 Milestone 5 |
Thanks for the feedback. |
|
Since the update to 4.1, the coordinates issue has been solved for me with the last fix, but the event stream no longer works. in the trace I see that the streaming connection is established once, but the second request gets “error” as a response, see in the log file at: 2023-12-30 10:25:50.293 @kaikreuzer @psmedley 2023-12-30 10:25:39.148 [DEBUG] [.internal.handler.TeslaEventEndpoint] - TeslaEventEndpoint-tesla:model3:9538692daa:5YJ3E7EB3MF825xxx : Starting the client to connect to wss://streaming.vn.teslamotors.com/streaming/ |
|
There's still a (different) bug in how the location is updated on the items, namely it's done as 2 separate updates, leading to bogus lat/long when coming online. OH restarted, everything is null, wake up the car, debug trace shows this series of events: Ignore the timestamps, I must've grabbed the first part from a later cycle. Anyway, the location update must be done for lat+long at the same time, not sequentially as the data is being parsed. I'll take a crack at this next year, but don't hold your breath... |
Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Fixes #15878 (comment)
I tracked this down to a bug which used to update the location from both the location information as well as the "active route location" information, which seems to be delivered by Tesla even though no route is active while the car stays at home.
By cleanly separating these two location types now, the frequent location updates while the car is at home should not appear anymore.