Create first version of nox-utils #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
One other thing to note: this assumes that we will use a |
Contributor
Author
|
opendp/tumult-core#2 shows most of the changes needed to make use of this -- I still need to clean up the noxfile a bit and fix some lints that have mysteriously appeared, but it should give a sense of what this will look like. |
Maegereg
reviewed
May 13, 2025
Maegereg
reviewed
May 13, 2025
7c63b1c to
26827b5
Compare
This `nox_utils` is based on `nox_utils` as it existed in opendp/tumult-analytics@f534dd2, but it contains some significant changes: * Sessions now use Poetry dependency groups to figure out what packages to install, rather than listing all of the packages explicitly. As a result, `nox_poetry` is no longer needed to ensure that the package versions nox installs match those in the Poetry lock. This should both allow for more per-package customization and minimize the number of code changes required in this repository. * The main class for creating sessions has been renamed and its constructor has been significantly changed. Most notably, it now takes options directly as keyword arguments. * `nox_utils` is now linted, and uses itself to set up its own noxfile. Not all sessions that were previously available have been set up yet. So far lint, test, docs, and dependency audit sessions are available; more will be added over time, but this should cover basic development needs up until we need to make a release.
Maegereg
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
nox_utilsis based onnox_utilsas it existed in opendp/tumult-analytics@f534dd2, but it contains some significant changes:nox_poetryis no longer needed to ensure that the package versions nox installs match those in the Poetry lock. This should both allow for more per-package customization and minimize the number of code changes required in this repository.nox_utilsis now linted, and uses itself to set up its own noxfile.Not all sessions that were previously available have been set up yet. So far lint, test, docs, and dependency audit sessions are available; more will be added over time, but this should cover basic development needs up until we need to make a release.