这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Maegereg
Copy link
Contributor

@Maegereg Maegereg commented Oct 10, 2025

The new syntax is nice, but also this avoids the python 3.14 sphinx issues we've been encountering.

I think I prefer this to any of the other options:

  • Linking to an older version of the python documentation is non-standard, and gives us another place in the codebase we need to remember to periodically update.
  • Ignoring the warnings seems like a bad idea because this is a real issue.
  • Switching the code to use the new union syntax everywhere seems like a lot of effort, though we may want to do it in the long term.
  • Writing a custom formatter for sphinx_autodoc_typehints would be pretty hacky.

@Maegereg Maegereg added this pull request to the merge queue Oct 10, 2025
Merged via the queue into main with commit 2b2428c Oct 10, 2025
3 checks passed
@Maegereg Maegereg deleted the dasm/union-docs-fix branch October 10, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants