-
Notifications
You must be signed in to change notification settings - Fork 2
Add the start of a release pipeline #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do we need to build in the |
Let me see if I can figure out how to avoid it.
That means |
5b3e8d5 to
d2238ff
Compare
|
Okay, I think this is much better now. I have avoided building Core as part of |
d2238ff to
c39afec
Compare
tmager
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this seems much clearer now, thanks for looking into it more. LGTM barring one minor comment.
Part of #29
This adds the tag check and build jobs, including mac builds for intel and arm.
I did have to make one tweak to the build process. We'd previously set the
MACOS_DEPLOYMENT_TARGETenvironment variable (which ensures that we're building wheels that are MacOS 11+ compatible, rather than 15+ based on VM OS) in thecibuildwheelsettings. But, when we douv run nox -s buildon a fresh machine, we first build as part of theuv runcall (which installs the current project), andcibuildwheel(which gets called in the nox session) re-uses the binaries built in that initial step. In other words, the caching means that we need the environment variable set whenever we're building the libraries, not just when we're usingcibuildwheel. I left the variable set in thecibuildwheelconfiguration so that we're specifying the target MacOS version explicitly, rather than relying on thecibuildwheeldefaults.