Add dependency matrix nox session #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmager
approved these changes
Sep 17, 2025
Contributor
tmager
left a comment
There was a problem hiding this comment.
Changes look fine to me, though I will point out that we just saw an example of somebody using Analytics with Spark 3.3.2 in Slack.
Contributor
Author
We've already made the spark dependency version changes in Analytics, so I'll go ahead and submit this. But do you think we should reconsider dropping pyspark 3.3 and 3.4? |
Contributor
|
I'm not entirely sure... it feels a bit odd to drop support for something we know one of our longest-term users still uses, but it also makes life a lot easier on our side. Might be worth asking Hal what the future looks like in terms of switching to a newer Spark version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered just bumping the minimum dependency versions, but this seems a bit different than the pyspark problem: no arm mac user is going to accidentally end up with dependencies in the invalid range, so there's no reason to preclude linux or x86 macs from using those versions.