这是indexloc提供的服务,不要输入任何密码
Skip to content

Fix linter issues #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix linter issues #10

wants to merge 2 commits into from

Conversation

Maegereg
Copy link
Contributor

@Maegereg Maegereg commented Jul 18, 2025

Fix a couple of lint issues that cropped up when I tried to re-enable the linters. In particular:

  • It seems like we no longer need a couple suppressions.
  • The version file is missing in the repository, so pylint catches that.

This is working towards #5

@Maegereg Maegereg requested a review from tmager July 18, 2025 03:02
@Maegereg Maegereg self-assigned this Jul 18, 2025
@tmager
Copy link
Contributor

tmager commented Jul 19, 2025

Pylint isn't giving me any warnings on main -- any idea why this behaves differently for you?

@Maegereg
Copy link
Contributor Author

Pylint isn't giving me any warnings on main -- any idea why this behaves differently for you?

For the version thing, I'm guessing it's because you have an (ignored) version file locally. For the suppressions, I'm not sure, but these are results based on the CI runner rather than my local machine (I still don't have Core building properly). You can see an example here: https://github.com/opendp/tumult-core/actions/runs/15932288349/job/44944848807 Do you get an error when these suppressions are removed?

@Maegereg
Copy link
Contributor Author

Pylint isn't giving me any warnings on main -- any idea why this behaves differently for you?

For the version thing, I'm guessing it's because you have an (ignored) version file locally. For the suppressions, I'm not sure, but these are results based on the CI runner rather than my local machine (I still don't have Core building properly). You can see an example here: https://github.com/opendp/tumult-core/actions/runs/15932288349/job/44944848807 Do you get an error when these suppressions are removed?

Update: I have the build working locally now, and I'm seeing the same thing you are: locally, lint passes on the old version and not the new one. But on a runner, it requires these changes. I will investigate further.

@Maegereg Maegereg marked this pull request as draft July 21, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants