Make noise selection logic a rewriting rule #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maegereg
reviewed
Oct 21, 2025
Maegereg
reviewed
Oct 22, 2025
TedTed
commented
Oct 23, 2025
Contributor
Author
TedTed
left a comment
There was a problem hiding this comment.
Thank you for the thoughtful review!
Maegereg
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step of moving compilation to use rewrite rules (similarly to what we do for KeySets) instead of the measurement visitor.
Along the way, it unifies error handling in the case where users select Gaussian noise with a non-RhoZCDP budget (there were previously some inconsistencies, and no unit tests with ApproxDP).