Add an anti-footgun option to dynamic versioning #51
Conversation
That's not why it's picking 0.8.2 (side note, 0.8.2 isn't the latest tag alphabetically - we have a bunch of 0.9.* tags). Something about the release machinery got screwed up after 0.8.2, and none of the tags after that are on the main branch - they're all on orphaned commits instead. So 0.8.2 is in fact the latest tag on the main branch. This should be fixed as soon as we make a new release, because then the latest tag will be on main. I don't object to adding this option, though - we don't intend to use tags for anything else, so the extra validation seems useful. |
|
As @Maegereg says, 0.8.2 is just the last release tag in the history of |
At present, running
make packagecreates files whose version number was totally absurd e.g. "0.8.2.post549+a3115dcb".My understanding is that this is because it would go through all existing tags and find the "latest" one… by alphabetical order.(Edit: this is not the correct explanation, see below.) So even if the current git tag is something like "0.20.2-rc.1" it would ignore it. Worse, if the current git tag is not recognized by our regex (say, because someone naively named it "v0.20.2-rc.1"), it would be silently ignored.This option tell it to just look at the last git tag, which solves both problems: it prevents it from looking at old stuff, and if the last git tag doesn't pass the regex test, it fails with a clear error message, so we immediately know what's going on.
Note: I'm not sure why it ever worked before, my guess is that the behavior of some tool changed between versions. But I think we want that option regardless.