这是indexloc提供的服务，不要输入任何密码
Skip to content

Removes python 3.9 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2025
Merged

Removes python 3.9 #57

merged 2 commits into from
Oct 6, 2025

Conversation

@cbaycity
Copy link
Contributor

@cbaycity cbaycity commented Oct 4, 2025

This PR remove Python 3.9, which reached End-Of-Life this month.

Issue: #38

@cbaycity cbaycity requested a review from Maegereg October 4, 2025 14:46
@cbaycity cbaycity self-assigned this Oct 4, 2025
tmager
tmager reviewed Oct 5, 2025
View reviewed changes
Copy link
Contributor

@tmager tmager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update .python-version. Otherwise this looks fine to me; we really should try to get PySpark 4 support in, only officially supporting two pretty old minor versions of Python is kind of rough.

@cbaycity @tmager
Update CHANGELOG.rst
50cd5b2 
Co-authored-by: Tom Magerlein <dev@tom.magerlein.com>
@cbaycity
Copy link
Contributor Author

cbaycity commented Oct 5, 2025

You also need to update .python-version. Otherwise this looks fine to me; we really should try to get PySpark 4 support in, only officially supporting two pretty old minor versions of Python is kind of rough.

I think I did update the .python-version file. I agree that we should support the new PySpark. I started that work and then got completely sidetracked moving from Seattle to NYC. Let me restart it.

tmager
tmager approved these changes Oct 5, 2025
View reviewed changes
Copy link
Contributor

@tmager tmager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I did update the .python-version file

Oh, I just can't read apparently, nvm. Looks good.

@cbaycity cbaycity added this pull request to the merge queue Oct 6, 2025
Merged via the queue into main with commit e09e4c0 Oct 6, 2025
3 checks passed
@cbaycity cbaycity deleted the remove-python-3.9 branch October 6, 2025 01:24
@Maegereg
Copy link
Contributor

Maegereg commented Oct 6, 2025

My only note is that we should do this for Core too.

@cbaycity
Copy link
Contributor Author

cbaycity commented Oct 6, 2025

My only note is that we should do this for Core too.

I intent to! I am only doing this one at a time because I wanted to make sure that I understood every step that needed to happen before I submitted the PRs. Turns out I had a pretty good understanding of things though! You'll have a Core PR tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmager tmager tmager approved these changes

@Maegereg Maegereg Awaiting requested review from Maegereg

Assignees

@cbaycity cbaycity

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cbaycity @Maegereg @tmager