这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Maegereg
Copy link
Contributor

Fixes #43

@Maegereg Maegereg requested a review from cbaycity August 11, 2025 18:04
@Maegereg Maegereg self-assigned this Aug 11, 2025
@Maegereg Maegereg force-pushed the dasm/no-fork-actions branch from 3c74a3f to b83f257 Compare August 11, 2025 18:20
@cbaycity
Copy link
Contributor

@Maegereg This PR looks good generally and should work well. Do you need to make similar changes to the merge_queue.yml file too?

Some jobs, like package, are shared across these files. Is it possible for us to the job once and then import it into the other yml files?
Like this: https://docs.github.com/en/actions/how-tos/reuse-automations/reuse-workflows?learn=getting_started&learnProduct=actions

@Maegereg
Copy link
Contributor Author

Do you need to make similar changes to the merge_queue.yml file too?

I wasn't planning to - there's nothing in the merge queue that's repository-specific. It won't cause any failures in a fork.

Some jobs, like package, are shared across these files. Is it possible for us to the job once and then import it into the other yml files?

Looks like that should work. I can work on that in a follow-up issue. I filed #46

Copy link
Contributor

@cbaycity cbaycity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Note: The failed check is the release job that shouldn't have triggered. A separate PR is being pushed to resolve those issues.

@Maegereg Maegereg added this pull request to the merge queue Aug 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2025
@Maegereg Maegereg added this pull request to the merge queue Aug 12, 2025
Merged via the queue into main with commit f6b83c5 Aug 12, 2025
5 of 6 checks passed
@Maegereg Maegereg deleted the dasm/no-fork-actions branch August 12, 2025 01:17
@TedTed TedTed added good first issue Good for newcomers and removed good first issue Good for newcomers labels Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make sure invalid CI workflows don't run on forked repositories

4 participants